Closed Bug 1239673 Opened 5 years ago Closed 5 years ago

Memory table striping (row background colors) inconsistent when scrolling

Categories

(DevTools :: Memory, defect, P3)

defect

Tracking

(firefox46 fixed)

RESOLVED FIXED
Firefox 46
Tracking Status
firefox46 --- fixed

People

(Reporter: jdescottes, Assigned: jdescottes)

References

(Blocks 1 open bug)

Details

Attachments

(1 file, 2 obsolete files)

STRs : 
- go to any page
- open devtools
- go to memory tool
- expand nodes in order to trigger a vertical scrollbar
- pay attention to which row has a white or a blue background
- scroll

Actual : 
The blue background jumps from one element to the other.

Expected :
An element with a blue background should always have a blue background, regardless of the scroll.
On windows 10, the alternate background color sort of flickers as you scroll. If you use the DOWN arrow key to scroll down line by line, the color does change as Julian reported.
Has STR: --- → yes
Priority: -- → P3
Attached patch bug1239673.wip.diff (obsolete) — Splinter Review
Work in progress.
 
The odd colouring was done in CSS (nth-child). Since items are rendered from a start index which depends on the scroll, the coloring moves with the scroll.
Instead this patch attaches an 'odd' prop to TreeNodes, which then render an "odd" class if present.
Assignee: nobody → jdescottes
Status: NEW → ASSIGNED
Attached patch bug1239673.v1.diff (obsolete) — Splinter Review
Attachment #8708129 - Attachment is obsolete: true
Attachment #8709216 - Flags: feedback?(vporof)
Comment on attachment 8709216 [details] [diff] [review]
bug1239673.v1.diff

Review of attachment 8709216 [details] [diff] [review]:
-----------------------------------------------------------------

yup
Attachment #8709216 - Flags: feedback?(vporof) → feedback+
Try : https://treeherder.mozilla.org/#/jobs?repo=try&revision=b31cfe79cc14

Carry over f+ as r+ since it is a minor change.
Attachment #8709216 - Attachment is obsolete: true
Attachment #8709746 - Flags: review+
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/1cf358aab01b
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 46
[bugday-20160323]

Status: RESOLVED,FIXED -> VERIFIED

Comments: Test successful
STR: clear.


Component: 
Name			Firefox
Version			46.0b9
Build ID		20160322075646
Update Channel          beta
User Agent		Mozilla/5.0 (Windows NT 6.1; WOW64; rv:46.0) Gecko/20100101 Firefox/46.0
OS			Windows 7 SP1 x86_64

Expected Results: 
Blue background after every single line 

Actual Results: 
As expected
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.