1239673 - Memory table striping (row background colors) inconsistent when scrolling

Status: RESOLVED FIXED

(DevTools :: Memory, defect, P3)

Description

[Julian Descottes [:jdescottes]]

STRs : 
- go to any page
- open devtools
- go to memory tool
- expand nodes in order to trigger a vertical scrollbar
- pay attention to which row has a white or a blue background
- scroll

Actual : 
The blue background jumps from one element to the other.

Expected :
An element with a blue background should always have a blue background, regardless of the scroll.

Comment 1

[Patrick Brosset <:pbro>]

On windows 10, the alternate background color sort of flickers as you scroll. If you use the DOWN arrow key to scroll down line by line, the color does change as Julian reported.

Comment 2

[Julian Descottes [:jdescottes]]

Attachment: bug1239673.wip.diff

Work in progress.
 
The odd colouring was done in CSS (nth-child). Since items are rendered from a start index which depends on the scroll, the coloring moves with the scroll.
Instead this patch attaches an 'odd' prop to TreeNodes, which then render an "odd" class if present.

Comment 3

[Julian Descottes [:jdescottes]]

Attachment: bug1239673.v1.diff

Comment 4

[Victor Porof [:vporof][:vp]]

Comment on attachment 8709216 [details] [diff] [review]
bug1239673.v1.diff

Review of attachment 8709216 [details] [diff] [review]:
-----------------------------------------------------------------

yup

Comment 5

[Julian Descottes [:jdescottes]]

Attachment: bug1239673.v2.diff

Try : https://treeherder.mozilla.org/#/jobs?repo=try&revision=b31cfe79cc14

Carry over f+ as r+ since it is a minor change.

Comment 6

[Julian Descottes [:jdescottes]]

New try push : https://treeherder.mozilla.org/#/jobs?repo=try&revision=99d7b919d2fd

Comment 7

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/1cf358aab01b

Comment 8

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/1cf358aab01b

Comment 9

[Mayur Patil]

[bugday-20160323]

Status: RESOLVED,FIXED -> VERIFIED

Comments: Test successful
STR: clear.


Component: 
Name			Firefox
Version			46.0b9
Build ID		20160322075646
Update Channel          beta
User Agent		Mozilla/5.0 (Windows NT 6.1; WOW64; rv:46.0) Gecko/20100101 Firefox/46.0
OS			Windows 7 SP1 x86_64

Expected Results: 
Blue background after every single line 

Actual Results: 
As expected