123975 - [rfe]Clean up component descriptions.

Status: VERIFIED FIXED

(SeaMonkey :: Installer, enhancement)

Description

[Curt Patrick (gone)]

As per Jatin's instructions (history of this is found in bug 122697) the
following components should have the corresponding descriptions:

Navigator - "for web browsing" 
Mail & Newsgroups- "for reading email and newsgroups" 
Instant Messenger - "for instant messaging" 
Spell Checker - "for checking the spelling of your email/web pages" 
Sun Java 2 - "for using Java applets" 
Quality Feedback Agent - "for reporting Netscape crash information" 
AOL ART Extensions - "for viewing images that use the AOL ART format"
Net2Phone - "for making Internet-based calls"
Macromedia Flash Player - "for viewing interactive Flash animations"
RealPlayer 8 - "for playing streaming music and video"
Winamp - "for playing MP3 and audio files"
HP Printer Identifier Plugin - "for identifying printers within Print Plus"
Classic Skin - "for a classic Navigator look"
Canadian Region Pack - "Regional content for Canadian users"
Latin American Region Pack - "Regional content for Latin American users"
UK Region Pack - "Regional content for UK users"

Comment 1

[Henrik Gemal]

what about for once also sync'ing the Mac and Linux installer...:) ?
So platform=All

Comment 2

[Curt Patrick (gone)]

Jatin, sere are some strings which are missing from the list you gave me (I
think).  PSM is missing for both ns and mozilla.  The others are mozilla
components.  Can you provide me with the descriptions you'd like to use for
these components:

Netscape Personal Security Manager - "Personal Security Manager (PSM) for crypto
operations"

Chatzilla - "IRC Client"

Debugger - "JavaScript debugger"

Inspector - "DOM inspector"

Comment 3

[Jatin Billimoria]

My suggested wordings:

Netscape Personal Security Manager - "For managing your security and encryption
settings"

Chatzilla - "For chatting on Internet Relay Chat(IRC)"

Debugger - "For debugging JavaScript"

Inspector - "For inspecting and editing Document Object Model(DOM)"

Comment 4

[Curt Patrick (gone)]

Attachment: 0.1 for mozilla windows

Comment 5

[Curt Patrick (gone)]

Attachment: 0.1 for ns windows

Comment 6

[Syd Logan]

Comment on attachment 68901 [details] [diff] [review]
0.1 for mozilla windows

+Description ShortFor inspecting and editing Document Object Model(DOM)


(missing equal sign) -- is there a way to test all of these to make sure they
display correctly, I imagine that would have failed. Also, some of these start
with lowercase "for", and some with uppercase "For" -- I'd imagine we would
want consistency there.

Comment 7

[Jatin Billimoria]

Yes, Syd. Thanks for catching that. The capital F in "for" should be lower-case.

Comment 8

[Syd Logan]

plussing

Comment 9

[Curt Patrick (gone)]

Attachment: 0.2 for mozilla

I did, in fact, check all the changes...and then I made a "trivial" change and
got caught.

This has equals where they go and not "For" where it should be "for"

Comment 10

[Curt Patrick (gone)]

Attachment: 0.2 for ns

One of the "For"'s had snuck in here also.

Comment 11

[Curt Patrick (gone)]

Attachment: 0.3 for mozilla

Got carried away with that last diff and picked up a change for a different
bug.

Comment 12

[Daniel Veditz [:dveditz]]

Comment on attachment 68958 [details] [diff] [review]
0.2 for ns

> [Component Instant Messenger]
> Description Short=Instant Messenger
> ;*** LOCALIZE ME BABY ***
>-Description Long=AOL community Instant Messenger client
>+Description Long=for instant messaging

Isn't the fact that it's *AOL* instant messenger important?
(this is a question for marketing...)

Also, this component is required for mail to be able to access AOL
mail or netscape.com web mail, a fact which we don't document and
is not obvious to people (even Netscape people). One way to solve
the problem is to combine NIM and messenger installs into a single
choice, or maybe we say more here. Dunno...


> Description Short=Netscape Personal Security Manager
> ;*** LOCALIZE ME BABY ***
>-Description Long=Personal Security Manager (PSM) for crypto operations
>+Description Long=for managing your security and encryption settings

This one's invisible in netscape anyway, but the Mozilla folks have had
problems when people have deselected this one not realizing it's
required for https access.

>-Description Long=Internet phone dialer
>+Description Long=for making Internet-based calls

I'd stick the word "phone" or "telephone" in there before "calls".

Comment 13

[Daniel Veditz [:dveditz]]

Comment on attachment 68960 [details] [diff] [review]
0.3 for mozilla

>-Description Long=IRC Client
>+Description Long=for chatting on Internet Relay Chat(IRC)

"chatting" seems redundant

>-Description Long=Regional contents for US users
>+Description Long=Regional content for US users

So they don't all have to start with "for"? in that case the
Chatzilla description might be better "client for Internet
Relay Chat (IRC)"

>-Description Long=Tool for reporting software crashes
>+Description Long=for reporting Netscape crash information

I wouldn't use "Netscape" here. I think you could drop Netscape
entirely rather than trying to stick "Mozilla" or something in there.

>-Description Long=Personal Security Manager (PSM) for crypto operations
>+Description Long=for managing your security and encryption settings

We really need to add something about https in here. I think there's
another bug somewhere that discusses this one, might have some tips.

Comment 14

[Curt Patrick (gone)]

Jatin, Gregg, any comments?

Comment 15

[Jatin Billimoria]

Some comments in response to Dan:

"Isn't the fact that it's *AOL* instant messenger important?
(this is a question for marketing...)"

To be more specific, I suggest:
"for AOL instant messaging"

"Also, this component is required for mail to be able to access AOL
mail or netscape.com web mail, a fact which we don't document and
is not obvious to people (even Netscape people). One way to solve
the problem is to combine NIM and messenger installs into a single
choice, or maybe we say more here. Dunno..."

This is more of a release notes issue (unless fixed) and should be adding to the
latest release notes tracking bug.

"This one's invisible in netscape anyway, but the Mozilla folks have had
problems when people have deselected this one not realizing it's
required for https access."

Notes about installation usually go in the ReadMe file, the Mozilla ReadMe in
this case. Asa is handling ReadMe issues on the Mozilla side.

"I'd stick the word 'phone' or 'telephone' in there before 'calls'."

Sounds OK with me, although I originally didn't want to infer that a phone was
used to make the call. 

"'chatting' seems redundant"

I feel chatting is the best way of describing what the user does when using IRC.

"So they don't all have to start with 'for'? in that case the
Chatzilla description might be better 'client for Internet
Relay Chat (IRC)'"

The descriptions for content pack were OK as they were, and I felt that they
didn't need to be consistent with the others using "for" since they dealt less
with an activity and more with content.

"I wouldn't use 'Netscape' here. I think you could drop Netscape
entirely rather than trying to stick 'Mozilla' or something in there."

Unless we can use the short variable, we can remove "Netscape."

Comment 16

[Curt Patrick (gone)]

Steve, there is a release note requirement mentione in Jatin's last comments (#15)

Comment 17

[Curt Patrick (gone)]

So it looks like I need to change the following 3 strings to be:

String 1:
--------
"for AOL instant messaging"

String 2:
--------
"for making Internet-based phone calls"

String 3:
--------
I can do any one of the following:
  1) "for reporting $ProductName$ crash information" 
  2) "for reporting [hardcode Mozilla or Netscape] crash information"
  3) "for reporting crash information"
Since the crash info is specifically for the client (not other unrelated
products) I lean toward 1) or 2).  Choice one ends up being "Netscape 6" right
now as opposed to just "Netscape" which seems to work okay in my book.  That is
what I'll go with unless you say differently.

Dan, Jatin, please give me a thumbs up (or down) on these proposed changes
before I implement.

Comment 18

[Daniel Veditz [:dveditz]]

thumbs up from me...

Comment 19

[Curt Patrick (gone)]

Attachment: 0.4 for mozilla

Corrected the text.  Using $ProductName$ in Talkback description.

Comment 20

[Curt Patrick (gone)]

Attachment: 0.4 for ns

Same changes for ns.

Comment 21

[dprice (gone)]

Comment on attachment 69788 [details] [diff] [review]
0.4 for mozilla

r=dprice ship it!

Comment 22

[dprice (gone)]

Comment on attachment 69789 [details] [diff] [review]
0.4 for ns

r=dprice

Comment 23

[Syd Logan]

Comment on attachment 69789 [details] [diff] [review]
0.4 for ns

Since I can sr= for ns tree, here ya go. Looks good.

Comment 24

[Daniel Veditz [:dveditz]]

Comment on attachment 69788 [details] [diff] [review]
0.4 for mozilla

> [Component PSM]
> Description Short=Personal Security Manager
> ;*** LOCALIZE ME BABY ***
>-Description Long=Personal Security Manager (PSM) for crypto operations
>+Description Long=for managing your security and encryption settings
> Archive=psm.xpi
> $InstallSize$:psm
> $InstallSizeSystem$

Mozilla absolutely has to have a better description for PSM, see the
discussion in bug 116703 for why and various options. From that bug

  Cryptography component - required for HTTPS, S/MIME, SSL, etc. support
  Crypto support, required to do SSL (HTTPS), S/MIME, and whatever

Keeping with the "for..." style, how 'bout

  for secure browsing and email, required for SSL(https) and S/MIME

PSM does certificate management, too, but the folks who care about that
will already know. It's the people who don't equate the "security' or
"crypto" terms with being able to bank or shop that get tripped up.

This might be an OK time to break the "for..." style and start out
with "REQUIRED for..."

Comment 25

[Curt Patrick (gone)]

I just checked in the ns patch since it has all the reviews it needs.

Dan, I'm not the right person to decide the best wording for the PSM description
for mozilla.  Whose input do we need besides yours?  (BTW, if we go with your
"for..." suggestion, it seems to me that a semicolon is more correct than a
comma, but I tend to overuse semicolons.)

When we settle on PSM wording for mozilla I'll be glad to make the same
modification to NS if Gregg, Jatin and/or others want to go with it.  Seems like
the same concerns apply as for Mozilla.

Comment 26

[Daniel Veditz [:dveditz]]

Comment on attachment 69788 [details] [diff] [review]
0.4 for mozilla

In the interests of getting this checked in, go with my wording and your
semi-colon and call it a day. With that change, sr=dveditz

ns wording is irrelevant as PSM is invisible anyway. We'll leave bug 116703
open to cover the potential re-ordering and any objections to the wording
change.

Comment 27

[Curt Patrick (gone)]

Okay, Windows is checked in for both mozilla and ns, using the suggested PSM
wording.  Still got linux and mac to go.

Comment 28

[Curt Patrick (gone)]

Attachment: ns, unix descriptions

Comment 29

[Curt Patrick (gone)]

Attachment: moz, unix descriptions

Comment 30

[Curt Patrick (gone)]

Attachment: mozilla, mac descriptions

Comment 31

[Curt Patrick (gone)]

Attachment: ns, mac descriptions

Comment 32

[J.J. Enser]

Comment on attachment 71369 [details] [diff] [review]
mozilla, mac descriptions

r=jj, assuming the new wording for module description has been approved.

Comment 33

[J.J. Enser]

Comment on attachment 71370 [details] [diff] [review]
ns, mac descriptions

r=jj, assuming the new wording for module description has been approved.

Comment 34

[Grace Bush]

nsbeta1+ issues for Win Installer

Comment 35

[Daniel Veditz [:dveditz]]

Comment on attachment 71369 [details] [diff] [review]
mozilla, mac descriptions

sr=dveditz

Comment 36

[Daniel Veditz [:dveditz]]

Comment on attachment 71370 [details] [diff] [review]
ns, mac descriptions

sr=dveditz

Comment 37

[Daniel Veditz [:dveditz]]

Comment on attachment 71357 [details] [diff] [review]
moz, unix descriptions

sr=dveditz

Comment 38

[Daniel Veditz [:dveditz]]

Comment on attachment 71355 [details] [diff] [review]
ns, unix descriptions

sr=dveditz

Comment 39

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Comment on attachment 71357 [details] [diff] [review]
moz, unix descriptions

a=dbaron for trunk checkin

Comment 40

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Comment on attachment 71369 [details] [diff] [review]
mozilla, mac descriptions

a=dbaron for trunk checkin

Comment 41

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Comment on attachment 71357 [details] [diff] [review]
moz, unix descriptions

>RCS file: /cvsroot/mozilla/xpinstall/packager/unix/config.it,v
>@@ -103,7 +103,7 @@
> [Component0]
> Description Short=XPInstall Engine
> ; *** LOCALIZE ME BABY ***
>-Description Long=Installer technology
>+Description Long=for web browsing
> Archive=xpcom.xpi
> $InstallSize$:xpcom
> $InstallSizeArchive$:xpcom.xpi

Actually, doesn't this change belong under [Component0] rather than
[Component1]?  Removing the approval mark for this one since it didn't
have review noted, either.

Comment 42

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

I said that backwards: doesn't the change belong under [Component1] rather than
[Component0]?

Comment 43

[Curt Patrick (gone)]

Attachment: 0.2 moz, unix descriptions

dbaron is correct, I put one description with the wrong component.  This fixes
that.

Comment 44

[Curt Patrick (gone)]

Checked in the mozilla mac patch.

Comment 45

[Curt Patrick (gone)]

Checked in the ns mac also, so I'm waiting on r= for both unix patches, and need
a new sr= for the mozilla unix patch as well.

Comment 46

[Daniel Veditz [:dveditz]]

Comment on attachment 72334 [details] [diff] [review]
0.2 moz, unix descriptions

Use your best judgement, but for small corrections in response to a review you
don't usually need to get lower-level re-review. An OK from dbaron/drivers
should suffice.

Comment 47

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Comment on attachment 72334 [details] [diff] [review]
0.2 moz, unix descriptions

a=dbaron for trunk checkin

Comment 48

[Curt Patrick (gone)]

Checked in the mozilla unix descriptions.

Comment 49

[Grace Bush]

verified all platforms 3/11 builds (NS and Mozilla)