Closed Bug 1239787 Opened 4 years ago Closed 4 years ago

crash in java.lang.NullPointerException: at org.mozilla.gecko.tabqueue.TabQueueService$3.onClick(TabQueueService.java)

Categories

(Firefox for Android :: Overlays, defect, critical)

All
Android
defect
Not set
critical

Tracking

()

RESOLVED FIXED
Firefox 46
Tracking Status
firefox44 --- fixed
firefox45 --- fixed
firefox46 --- fixed

People

(Reporter: sebastian, Assigned: sebastian)

References

(Blocks 1 open bug)

Details

(Keywords: crash)

Crash Data

Attachments

(1 file)

This bug was filed from the Socorro interface and is 
report bp-18b5d974-9862-4c22-81e8-d243f2160113.
=============================================================

e.g.: https://crash-stats.mozilla.com/report/index/18b5d974-9862-4c22-81e8-d243f2160113
> java.lang.NullPointerException
>     at org.mozilla.gecko.tabqueue.TabQueueService$3.onClick(TabQueueService.java:187)
https://reviewboard.mozilla.org/r/31071/#review27901

::: mobile/android/base/java/org/mozilla/gecko/tabqueue/TabQueueService.java
(Diff revision 1)
> -        tabQueueHandler = null;

I don't see the need to clear the Handler reference in onDestroy. The reference is not static so it's going away with the service instance anyways. Currently it can happen that we clear the reference and at the same time the user clicks on "Open" (OnClickListener implementation is accessing the Handler).
Comment on attachment 8708511 [details]
MozReview Request: Bug 1239787 - TabQueueService: Do not clear tabQueueHandler reference. r?ahunt

https://reviewboard.mozilla.org/r/31071/#review27923

Looks good - that does seem unnecessary!
Attachment #8708511 - Flags: review?(ahunt) → review+
https://hg.mozilla.org/mozilla-central/rev/38ba884086c7
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 46
Comment on attachment 8708511 [details]
MozReview Request: Bug 1239787 - TabQueueService: Do not clear tabQueueHandler reference. r?ahunt

Approval Request Comment

[Feature/regressing bug #]: Saw this bug in our crashstats and fixed it. Requesting uplift to lower the crash rate. Crash reports: https://crash-stats.mozilla.com/report/list?range_unit=days&range_value=28&signature=java.lang.NullPointerException%3A+at+org.mozilla.gecko.tabqueue.TabQueueService%243.onClick%28TabQueueService.java%29#tab-reports

[User impact if declined]: With tab queues the app can crash after the user clicked on "OPEN" in the tab queue overlay.

[Describe test coverage new/current, TreeHerder]: This is not easy reproducible because you need to time the click exactly to trigger this NullPointerException (With lots of users this statistically happens nevertheless).

[Risks and why]: Low - The patch avoid clearing the reference to early causing the NullPointerException.

[String/UUID change made/needed]: -
Attachment #8708511 - Flags: approval-mozilla-beta?
Attachment #8708511 - Flags: approval-mozilla-aurora?
Comment on attachment 8708511 [details]
MozReview Request: Bug 1239787 - TabQueueService: Do not clear tabQueueHandler reference. r?ahunt

One-liner Fennec crash fix. Taking it in Fennec 44.0 RC1
Attachment #8708511 - Flags: approval-mozilla-beta? → approval-mozilla-release+
Comment on attachment 8708511 [details]
MozReview Request: Bug 1239787 - TabQueueService: Do not clear tabQueueHandler reference. r?ahunt

Just like 44!
Attachment #8708511 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
You need to log in before you can comment on or make changes to this bug.