Closed Bug 1239838 Opened 5 years ago Closed 5 years ago

Don't see a way to redirect a needinfo request (in Experimental UI)


( :: User Interface, defect)

Not set





(Reporter: bzbarsky, Unassigned)


(Blocks 2 open bugs)



(2 files)

In the non-experimental UI, needinfo requests are surfaced in two bits of UI:

1)  An "I am providing ..." checkbox under the comment area and a "Need more information" checkbox under the comment area, with the latter allowing you to select whom to ask for info.

2)  A flag in the "Flags" section that can be set to "?" and then you enter whom you want info from.

In the experimental UI, UI #2 seems to be gone.  There's an "Update" button in the "People" section which just jumps you to UI #1.

The problem is that UI #1 doesn't allow _redirecting_ a needinfo request: changing the requestee while leaving the requester the same.  The idea is to have the original requester notified when the request is responded to, instead of whoever is making the change getting notified.  With the non-experimental UI, this can be done in a slightly hacky way as follows:

* Change the username listed in the Flags section
* Ensure the "I am providing..." checkbox (which is checked by default if
  you're the requestee) is unchecked.

In the experimental UI I don't see a way to do this at all.  This is a pretty common operation on needinfo requests that I think we should add better support for in general, not remove support for.
Blocks: 1150541
I just ran into this as well, and needed to turn off experimental UI in order to make bug 1250824 comment 3, and then turn it back on.
Summary: Don't see a way to redirect a needinfo request → Don't see a way to redirect a needinfo request (in Experimental UI)
Assignee: nobody → glob
Attached patch 1239838_1.patch β€” β€” Splinter Review
unchecking your "clear needinfo request" changes 'Need more information from' to 'Redirect my needinfo request to'

- YUI --> jquery
- move all js into a single script block
- implement redirection
Attachment #8741646 - Flags: review?(dkl)
Attached image Screenshot of redirect UI β€”
Comment on attachment 8741646 [details] [diff] [review]

Review of attachment 8741646 [details] [diff] [review]:


I tested existing flags that are requesteeable with changing the requestee to multiple addresses and it does indeed work. The first address will take over the same flag id and the following addresses will get new flags. This works for both needinfo, review, etc. We could document this behavior or we could leave it alone in case we want to remove this behavior in the future for whatever reason.

Attachment #8741646 - Flags: review?(dkl) → review+
To ssh://
   8d6c922..d447aed  master -> master
Closed: 5 years ago
Resolution: --- → FIXED
Blocks: 1269939
No longer depends on: 1269939
Blocks: 1280989
No longer depends on: 1280989
Component: User Interface: Modal → User Interface
Assignee: glob → nobody
You need to log in before you can comment on or make changes to this bug.