Closed Bug 1239866 Opened 9 years ago Closed 9 years ago

Remove signaling standalone tests

Categories

(Core :: WebRTC: Signaling, defect)

Product:
Core
Component:
WebRTC: Signaling
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla46
Tracking Flags:
Tracking Status
firefox46 --- fixed

People

(Reporter: erahm, Assigned: erahm)

References

Details

Attachments

(1 file)

Remove signaling standalone tests
6.82 KB, patch
bwc
: review+
Details | Diff | Splinter Review
In order to remove libxpcomrt we need to remove the standalone variant of signaling tests. The non-standalone variant will remain so there should not be an impact on test coverage.
This removes the standalone version of the signaling tests in order to remove a dependency of libxpcomrt.
Attachment #8708490 - Flags: review?(docfaraday)
Assignee: nobody → erahm
Status: NEW → ASSIGNED
Comment on attachment 8708490 [details] [diff] [review] Remove signaling standalone tests Review of attachment 8708490 [details] [diff] [review]: ----------------------------------------------------------------- We need to get the standalone directory too, right?
Attachment #8708490 - Flags: review?(docfaraday) → review+
(In reply to Byron Campen [:bwc] from comment #3) > Comment on attachment 8708490 [details] [diff] [review] > Remove signaling standalone tests > > Review of attachment 8708490 [details] [diff] [review]: > ----------------------------------------------------------------- > > We need to get the standalone directory too, right? The best I can tell is that once it's empty it should just go away. I refreshed the patch using |hg remove media/webrtc/signaling/test/standalone| just in case.
https://hg.mozilla.org/mozilla-central/rev/00619fe541b0
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox46: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla46
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: