Closed
Bug 1239906
Opened 9 years ago
Closed 9 years ago
Deprecate nsIRadioInterfaceLayer.getClientIdForEmergencyCall()
Categories
(Firefox OS Graveyard :: RIL, defect)
Tracking
(firefox46 fixed)
RESOLVED
FIXED
| Tracking | Status | |
|---|---|---|
| firefox46 | --- | fixed |
People
(Reporter: edgar, Assigned: edgar)
References
Details
Attachments
(1 file)
TelephonyService can use the APIs of IccService directly, instead of having such API in nsIRadioInterfaceLayer.
|
Assignee | |
Updated•9 years ago
|
Blocks: b2g-ril-interface
|
|
Assignee | |
Comment 1•9 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/31017/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/31017/
|
|
Assignee | |
Updated•9 years ago
|
Assignee: nobody → echen
|
|
Assignee | |
Comment 2•9 years ago
|
||
|
|
Assignee | |
Updated•9 years ago
|
Attachment #8708189 -
Flags: review?(btseng)
|
||
Comment 3•9 years ago
|
||
Comment on attachment 8708189 [details]
MozReview Request: Bug 1239906 - Deprecate nsIRadioInterfaceLayer.getClientIdForEmergencyCall(); r=bevis
https://reviewboard.mozilla.org/r/31017/#review27837
r=me after the nit is addressed.
::: dom/telephony/gonk/TelephonyService.js:729
(Diff revision 1)
> + * @return clientId or -1 if none of the clients are avaialble.
nit:
-1 will never be returned in this function.
Attachment #8708189 -
Flags: review?(btseng) → review+
|
|
Assignee | |
Comment 4•9 years ago
|
||
(In reply to Bevis Tseng[:bevistseng][:btseng] from comment #3)
> Comment on attachment 8708189 [details]
> MozReview Request: Bug 1239906 - Deprecate
> nsIRadioInterfaceLayer.getClientIdForEmergencyCall()
>
> https://reviewboard.mozilla.org/r/31017/#review27837
>
> r=me after the nit is addressed.
>
> ::: dom/telephony/gonk/TelephonyService.js:729
> (Diff revision 1)
> > + * @return clientId or -1 if none of the clients are avaialble.
>
> nit:
> -1 will never be returned in this function.
Will do, thank you.
|
|
Assignee | |
Comment 5•9 years ago
|
||
Comment on attachment 8708189 [details]
MozReview Request: Bug 1239906 - Deprecate nsIRadioInterfaceLayer.getClientIdForEmergencyCall(); r=bevis
Review request updated; see interdiff: https://reviewboard.mozilla.org/r/31017/diff/1-2/
Attachment #8708189 -
Attachment description: MozReview Request: Bug 1239906 - Deprecate nsIRadioInterfaceLayer.getClientIdForEmergencyCall() → MozReview Request: Bug 1239906 - Deprecate nsIRadioInterfaceLayer.getClientIdForEmergencyCall(); r=bevis
| Comment hidden (obsolete) |
|
|
Assignee | |
Comment 7•9 years ago
|
||
|
|
Assignee | |
Updated•9 years ago
|
Keywords: checkin-needed
Keywords: checkin-needed
|
||
Comment 9•9 years ago
|
||
| bugherder | ||
You need to log in
before you can comment on or make changes to this bug.
Description
•