Closed Bug 1239907 Opened 9 years ago Closed 9 years ago

[TV][2.5] Improve and make l10n strings consistent for preview experience

Categories

(Firefox OS Graveyard :: Gaia::TV::System, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::TV::System
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(blocking-b2g:2.5+, b2g-v2.5 fixed, b2g-master fixed)

Status:
RESOLVED FIXED
Project Flags:
blocking-b2g 2.5+
Tracking Flags:
Tracking Status
b2g-v2.5 --- fixed
b2g-master --- fixed

People

(Reporter: rickychien, Assigned: rickychien)

References

Details

(Whiteboard: [ft:conndevices][partner-cherry-pick])

Attachments

(1 file)

[gaia] rickychien:new-strings > mozilla-b2g:master
46 bytes, text/x-github-pull-request
lchang
: review+
jocheng
: approval-gaia-v2.5+
Details | Review
Some of new strings in tv_apps/smart-system/locales/system.en-US.properties needs to be improved and make more consistent for words ex: applications folder to Apps. 1. added-to-apps={{name}} was added to Apps 2. deleted-from-apps={{name}} was deleted from Apps 3. add-app=Add {{name}} to Apps? 4. delete-from-apps=Remove
System banner will be updated for strings 1 and 2.
Depends on: 1239914
blocking-b2g: --- → 2.5?
blocking-b2g: 2.5? → 2.5+
Whiteboard: [ft:conndevices][partner-cherry-pick]
Comment on attachment 8708225 [details] [review] [gaia] rickychien:new-strings > mozilla-b2g:master Simple patch for updating l10n strings.
Attachment #8708225 - Flags: review?(lchang)
Comment on attachment 8708225 [details] [review] [gaia] rickychien:new-strings > mozilla-b2g:master Thanks.
Attachment #8708225 - Flags: review?(lchang) → review+
Landed in master: https://github.com/mozilla-b2g/gaia/commit/3fdecb198ed277770b765ad8be84f0ecf4a36a91
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Comment on attachment 8708225 [details] [review] [gaia] rickychien:new-strings > mozilla-b2g:master [Approval Request Comment] [Bug caused by] (feature/regressing bug #): none [User impact] if declined: inconsistent l10n string [Testing completed]: verified manually [Risk to taking this patch] (and alternatives if risky): none [String changes made]: added-to-apps={{name}} was added to Apps deleted-from-apps={{name}} was deleted from Apps add-app=Add {{name}} to Apps? delete-from-apps=Remove
Attachment #8708225 - Flags: approval-gaia-v2.5?
Comment on attachment 8708225 [details] [review] [gaia] rickychien:new-strings > mozilla-b2g:master Approve for TV 2.5
Attachment #8708225 - Flags: approval-gaia-v2.5? → approval-gaia-v2.5+
has conflicts uplifting to 2.5 - could you take a look and maybe provide a 2.5 PR request ? Thanks!
Flags: needinfo?(rchien)
curl -L https://github.com/rickychien/gaia/commit/6dca24ef8a3d104e0c02750ea32286541b4c1105.patch | git am ^^^ Take it!
Flags: needinfo?(rchien) → needinfo?(cbook)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: