Closed Bug 1239920 Opened 4 years ago Closed 4 years ago

Intermittent browser_console_netlogging.js | Logged network entry is page load - Got http://127.0.0.1:8888/dummy-gmp-manager.xml, expected http://example.com/browser/devtools/client/webconsole/test/test-network-request.html

Categories

(DevTools :: Console, defect, P1)

defect

Tracking

(e10s+, firefox47 fixed, firefox48 fixed)

RESOLVED FIXED
Firefox 48
Tracking Status
e10s + ---
firefox47 --- fixed
firefox48 --- fixed

People

(Reporter: philor, Assigned: sjakthol)

References

(Blocks 1 open bug)

Details

(Keywords: intermittent-failure, Whiteboard: [btpp-fix-now])

Attachments

(2 files)

Blocks: e10s-tests
tracking-e10s: --- → +
Summary: Intermittent e10s browser_console_netlogging.js | Logged network entry is page load - Got http://127.0.0.1:8888/dummy-gmp-manager.xml, expected http://example.com/browser/devtools/client/webconsole/test/test-network-request.html → Intermittent browser_console_netlogging.js | Logged network entry is page load - Got http://127.0.0.1:8888/dummy-gmp-manager.xml, expected http://example.com/browser/devtools/client/webconsole/test/test-network-request.html
Not sure if this was actually caused by Bug 1064458, or if that just moved the intermittent from browser_webconsole_netlogging.js into this file (which seems more likely).  Also, Bug 1234287 is refactoring this test so there's a chance that might fix the intermittent.
Depends on: 1234287
See Also: → 1064458
Priority: -- → P1
Whiteboard: [btpp-fix-now]
[bugday-20160323]

STR is unclear, so not able to verify.

Status: RESOLVED,FIXED --> UNVERIFIED

Component: 
Name 			Firefox
Version 		46.0b4
Build ID 		20160322075646
Update Channel 	        beta
User Agent 		Mozilla/5.0 (Windows NT 6.1; WOW64; rv:46.0) Gecko/20100101 Firefox/46.0
OS                      Windows 7 SP1 x86_64

Actual Results: 
As expected

Expected Results: 
Able to copy stack trace into copy buffer and able send it to developer.
[bugday-20160323]

STR is unclear, so not able to verify.

Status: NEW -> UNVERIFIED

Component: 
Name 			Firefox
Version 		46.0b4
Build ID 		20160322075646
Update Channel 	        beta
User Agent 		Mozilla/5.0 (Windows NT 6.1; WOW64; rv:46.0) Gecko/20100101 Firefox/46.0
OS                      Windows 7 SP1 x86_64
The problem here is that the test expects to receive a request for the
|test-network-request.html| but the waitForFinishedRequest() accepts any
request that happens to occur at the same time. In this particular bug,
a GMP update is triggered during the test and the waitForFinishedRequest()
promise resolves with that particular request which obviously isn't the
one the test was expecting.

These changes add an optional predicate function parameter to
waitForFinishedRequest() which will be called for each completed request
and the returned promise only resolves when the predicate returns true for
a request.

Also, browser_console_netlogging.js begins to use the aforementioned
functionality by passing a predicate that only accepts the request for
|test-network-request.html| effectively fixing the intermittent failure.

Review commit: https://reviewboard.mozilla.org/r/42391/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/42391/
Attachment #8734708 - Flags: review?(lclark)
If test timings shift in the future, the unexpected requests could occur
during any test. Since there are many tests that use waitForFinishedRequest(),
any of them could start to fail intermittently at any point.

These changes fix other usages of wwaitForFinishedRequest() to include a
predicate that ignores the requests that are unexpected during the test.

Review commit: https://reviewboard.mozilla.org/r/42393/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/42393/
Attachment #8734709 - Flags: review?(lclark)
Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=4fdf2c951e82
Assignee: nobody → sjakthol
Status: NEW → ASSIGNED
We'll need to reenable browser_webconsole_netlogging.js in e10s after this is applied, here's a try push with that enabled: https://treeherder.mozilla.org/#/jobs?repo=try&revision=bdb494d4fd3f
Comment on attachment 8734708 [details]
MozReview Request: Bug 1239920 - Ignore unexpected requests in browser_console_netlogging.js. r?linclark

https://reviewboard.mozilla.org/r/42391/#review39027

Looks good to me
Attachment #8734708 - Flags: review+
Comment on attachment 8734709 [details]
MozReview Request: Bug 1239920 - Fix other usages of waitForFinishedRequest() to ignore unexpected requests in webconsole tests. r?linclark

https://reviewboard.mozilla.org/r/42393/#review39029

Thanks!
Attachment #8734709 - Flags: review+
Comment on attachment 8734708 [details]
MozReview Request: Bug 1239920 - Ignore unexpected requests in browser_console_netlogging.js. r?linclark

Stole reviews
Attachment #8734708 - Flags: review?(lclark)
Attachment #8734709 - Flags: review?(lclark)
https://hg.mozilla.org/mozilla-central/rev/abf28569fff7
https://hg.mozilla.org/mozilla-central/rev/e04ad44074eb
https://hg.mozilla.org/mozilla-central/rev/5d52be560679
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 48
I'm still seeing the `TEST-UNEXPECTED-FAIL | devtools/client/webconsole/test/browser_webconsole_netlogging.js | Method is correct - Got GET, expected POST` on various e10s pushes since re-enabling this, like https://treeherder.mozilla.org/#/jobs?repo=try&revision=4145b5b8c69d&selectedJob=18815889.  But I guess we can handle whatever is still going on in Bug 1242234.
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.