1239963 - Stop unloading style sheets on shutdown

Status: RESOLVED FIXED

(Hello (Loop) :: Client, defect, P1)

Description

[Mark Banner (:standard8)]

Currently we are unloading our style sheets when we shut down the application. To aid performance, we can avoid doing that.

We can't stop un-initialising everything, as mochitests complain about leaks if we don't remove our listeners.

It appears that this is causing issues in some talos jobs for an unknown reason - see bug 1052467

Comment 1

[GitHub Autolander Bot]

Attachment: [loop] Standard8:bug-1239963-shutdown > mozilla:master

Comment 2

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/5dc5c6ab496c

Comment 3

[Mark Banner (:standard8)]

Landed:

https://github.com/Standard8/loop/commit/d74f51233425c0eb0a09d762f850584baf6b95bf

I also landed this directly in fx-team to hopefully stop the intermittents.

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/5dc5c6ab496c

Comment 5

[Ryan VanderMeulen [:RyanVM]]

Please request Aurora approval on this when you get a chance.

Comment 6

[Mark Banner (:standard8)]

Comment on attachment 8708265 [details] [review]
[loop] Standard8:bug-1239963-shutdown > mozilla:master

Approval Request Comment
[Feature/regressing bug #]: Loop as a system add-on.
[User impact if declined]: Sheriffs will need to mark more reds. Also, there may be a marginal perf improvement on shutdown (though I suspect it isn't measurable).
[Describe test coverage new/current, TreeHerder]: Landed in m-c.
[Risks and why]: Low, simple change to avoid doing unnecessary things on shutdown.
[String/UUID change made/needed]: none

Note: I'd like this to land after bug 1232707 to avoid bitrot.

Comment 7

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8708265 [details] [review]
[loop] Standard8:bug-1239963-shutdown > mozilla:master

Want to simplify the sheriff life, taking it.

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/bb50b210ccf3