Closed Bug 1239987 Opened 9 years ago Closed 9 years ago

Merge marionette-transport back into marionette-driver

Categories

(Testing :: Marionette Client and Harness, defect)

Product:
Testing
Component:
Marionette Client and Harness
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox47 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla47
Tracking Flags:
Tracking Status
firefox47 --- fixed

People

(Reporter: ato, Assigned: ato)

Details

(Keywords: pi-marionette-client, pi-marionette-runner)

Attachments

(4 files)

MozReview Request: Bug 1239987 - Merge marionette-transport into marionette-driver; r?automatedtester
58 bytes, text/x-review-board-request
automatedtester
: review+
Details
MozReview Request: Bug 1239987 - Change testing/marionette/client to use marionette.transport; r?automatedtester
58 bytes, text/x-review-board-request
automatedtester
: review+
Details
MozReview Request: Bug 1239987 - Remove marionette-transport dependency from build environment; r?gps
58 bytes, text/x-review-board-request
gps
: review+
Details
MozReview Request: Bug 1239987 - Remove marionette-transport dependency from DOM media tests; r?sydpolk
58 bytes, text/x-review-board-request
sydpolk
: review+
Details
The marionette-transport package was a mistake of my doing, and I don’t think anyone is depending solely on this package. Whilst modularisation is good, we are making life hard for ourselves by having to deal with yet another package. We should merge marionette-transport (transport.py) back into marionette-driver as a marionette.transport module.
Assignee: nobody → ato
Status: NEW → ASSIGNED
Keywords: ateam-marionette-runner
Comment on attachment 8713954 [details] MozReview Request: Bug 1239987 - Merge marionette-transport into marionette-driver; r?automatedtester Review request updated; see interdiff: https://reviewboard.mozilla.org/r/32921/diff/1-2/
Comment on attachment 8713955 [details] MozReview Request: Bug 1239987 - Change testing/marionette/client to use marionette.transport; r?automatedtester Review request updated; see interdiff: https://reviewboard.mozilla.org/r/32923/diff/1-2/
Comment on attachment 8713956 [details] MozReview Request: Bug 1239987 - Remove marionette-transport dependency from build environment; r?gps Review request updated; see interdiff: https://reviewboard.mozilla.org/r/32925/diff/1-2/
Comment on attachment 8713957 [details] MozReview Request: Bug 1239987 - Remove marionette-transport dependency from DOM media tests; r?sydpolk Review request updated; see interdiff: https://reviewboard.mozilla.org/r/32927/diff/1-2/
Attachment #8713954 - Flags: review?(dburns)
Attachment #8713955 - Flags: review?(dburns)
Attachment #8713956 - Flags: review?(gps)
Attachment #8713957 - Flags: review?(mjzffr)
Comment on attachment 8713954 [details] MozReview Request: Bug 1239987 - Merge marionette-transport into marionette-driver; r?automatedtester https://reviewboard.mozilla.org/r/32921/#review29763
Attachment #8713954 - Flags: review+
Comment on attachment 8713955 [details] MozReview Request: Bug 1239987 - Change testing/marionette/client to use marionette.transport; r?automatedtester https://reviewboard.mozilla.org/r/32923/#review29765
Attachment #8713955 - Flags: review+
Comment on attachment 8713954 [details] MozReview Request: Bug 1239987 - Merge marionette-transport into marionette-driver; r?automatedtester Review request updated; see interdiff: https://reviewboard.mozilla.org/r/32921/diff/2-3/
Comment on attachment 8713955 [details] MozReview Request: Bug 1239987 - Change testing/marionette/client to use marionette.transport; r?automatedtester Review request updated; see interdiff: https://reviewboard.mozilla.org/r/32923/diff/2-3/
Comment on attachment 8713956 [details] MozReview Request: Bug 1239987 - Remove marionette-transport dependency from build environment; r?gps Review request updated; see interdiff: https://reviewboard.mozilla.org/r/32925/diff/2-3/
Comment on attachment 8713957 [details] MozReview Request: Bug 1239987 - Remove marionette-transport dependency from DOM media tests; r?sydpolk Review request updated; see interdiff: https://reviewboard.mozilla.org/r/32927/diff/2-3/
Attachment #8713956 - Flags: review?(gps)
Comment on attachment 8713957 [details] MozReview Request: Bug 1239987 - Remove marionette-transport dependency from DOM media tests; r?sydpolk Review request updated; see interdiff: https://reviewboard.mozilla.org/r/32927/diff/3-4/
Attachment #8713957 - Attachment description: MozReview Request: Bug 1239987 - Remove marionette-transport dependency from DOM media tests; r?maja_zf → MozReview Request: Bug 1239987 - Remove marionette-transport dependency from DOM media tests; r?sydpolk
Attachment #8713957 - Flags: review?(spolk)
Comment on attachment 8713957 [details] MozReview Request: Bug 1239987 - Remove marionette-transport dependency from DOM media tests; r?sydpolk https://reviewboard.mozilla.org/r/32927/#review29809 LGTM. Thanks for fixing this nit.
Attachment #8713957 - Flags: review?(spolk) → review+
Comment on attachment 8713956 [details] MozReview Request: Bug 1239987 - Remove marionette-transport dependency from build environment; r?gps https://reviewboard.mozilla.org/r/32925/#review29887
Attachment #8713956 - Flags: review?(gps) → review+
Product: Testing → Remote Protocol

Moving bugs for Marionette client due to component changes.

Component: Marionette → Marionette Client and Harness
Product: Remote Protocol → Testing
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: