Closed
Bug 1239987
Opened 8 years ago
Closed 8 years ago
Merge marionette-transport back into marionette-driver
Categories
(Testing :: Marionette Client and Harness, defect)
Testing
Marionette Client and Harness
Tracking
(firefox47 fixed)
RESOLVED
FIXED
mozilla47
| Tracking | Status | |
|---|---|---|
| firefox47 | --- | fixed |
People
(Reporter: ato, Assigned: ato)
Details
(Keywords: pi-marionette-client, pi-marionette-runner)
Attachments
(4 files)
The marionette-transport package was a mistake of my doing, and I don’t think anyone is depending solely on this package. Whilst modularisation is good, we are making life hard for ourselves by having to deal with yet another package. We should merge marionette-transport (transport.py) back into marionette-driver as a marionette.transport module.
|
Assignee | |
Updated•8 years ago
|
Keywords: ateam-marionette-client
|
|
Assignee | |
Comment 1•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/32921/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/32921/
Attachment #8713954 -
Flags: review?(dburns)
|
|
Assignee | |
Comment 2•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/32923/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/32923/
Attachment #8713955 -
Flags: review?(dburns)
|
|
Assignee | |
Comment 3•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/32925/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/32925/
Attachment #8713956 -
Flags: review?(gps)
|
|
Assignee | |
Comment 4•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/32927/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/32927/
Attachment #8713957 -
Flags: review?(mjzffr)
|
|
Assignee | |
Updated•8 years ago
|
|
|
Assignee | |
Comment 5•8 years ago
|
||
Comment on attachment 8713954 [details] MozReview Request: Bug 1239987 - Merge marionette-transport into marionette-driver; r?automatedtester Review request updated; see interdiff: https://reviewboard.mozilla.org/r/32921/diff/1-2/
|
|
Assignee | |
Comment 6•8 years ago
|
||
Comment on attachment 8713955 [details] MozReview Request: Bug 1239987 - Change testing/marionette/client to use marionette.transport; r?automatedtester Review request updated; see interdiff: https://reviewboard.mozilla.org/r/32923/diff/1-2/
|
|
Assignee | |
Comment 7•8 years ago
|
||
Comment on attachment 8713956 [details] MozReview Request: Bug 1239987 - Remove marionette-transport dependency from build environment; r?gps Review request updated; see interdiff: https://reviewboard.mozilla.org/r/32925/diff/1-2/
|
|
Assignee | |
Comment 8•8 years ago
|
||
Comment on attachment 8713957 [details] MozReview Request: Bug 1239987 - Remove marionette-transport dependency from DOM media tests; r?sydpolk Review request updated; see interdiff: https://reviewboard.mozilla.org/r/32927/diff/1-2/
|
|
Assignee | |
Updated•8 years ago
|
Attachment #8713954 -
Flags: review?(dburns)
|
|
Assignee | |
Updated•8 years ago
|
Attachment #8713955 -
Flags: review?(dburns)
|
|
Assignee | |
Updated•8 years ago
|
Attachment #8713956 -
Flags: review?(gps)
|
|
Assignee | |
Updated•8 years ago
|
Attachment #8713957 -
Flags: review?(mjzffr)
|
||
Comment 9•8 years ago
|
||
Comment on attachment 8713954 [details] MozReview Request: Bug 1239987 - Merge marionette-transport into marionette-driver; r?automatedtester https://reviewboard.mozilla.org/r/32921/#review29763
Attachment #8713954 -
Flags: review+
|
|
||
Comment 10•8 years ago
|
||
Comment on attachment 8713955 [details] MozReview Request: Bug 1239987 - Change testing/marionette/client to use marionette.transport; r?automatedtester https://reviewboard.mozilla.org/r/32923/#review29765
Attachment #8713955 -
Flags: review+
|
|
Assignee | |
Comment 11•8 years ago
|
||
Comment on attachment 8713954 [details] MozReview Request: Bug 1239987 - Merge marionette-transport into marionette-driver; r?automatedtester Review request updated; see interdiff: https://reviewboard.mozilla.org/r/32921/diff/2-3/
|
|
Assignee | |
Comment 12•8 years ago
|
||
Comment on attachment 8713955 [details] MozReview Request: Bug 1239987 - Change testing/marionette/client to use marionette.transport; r?automatedtester Review request updated; see interdiff: https://reviewboard.mozilla.org/r/32923/diff/2-3/
|
|
Assignee | |
Comment 13•8 years ago
|
||
Comment on attachment 8713956 [details] MozReview Request: Bug 1239987 - Remove marionette-transport dependency from build environment; r?gps Review request updated; see interdiff: https://reviewboard.mozilla.org/r/32925/diff/2-3/
|
|
Assignee | |
Comment 14•8 years ago
|
||
Comment on attachment 8713957 [details] MozReview Request: Bug 1239987 - Remove marionette-transport dependency from DOM media tests; r?sydpolk Review request updated; see interdiff: https://reviewboard.mozilla.org/r/32927/diff/2-3/
|
|
Assignee | |
Updated•8 years ago
|
Attachment #8713956 -
Flags: review?(gps)
|
|
Assignee | |
Comment 15•8 years ago
|
||
Comment on attachment 8713957 [details] MozReview Request: Bug 1239987 - Remove marionette-transport dependency from DOM media tests; r?sydpolk Review request updated; see interdiff: https://reviewboard.mozilla.org/r/32927/diff/3-4/
Attachment #8713957 -
Attachment description: MozReview Request: Bug 1239987 - Remove marionette-transport dependency from DOM media tests; r?maja_zf → MozReview Request: Bug 1239987 - Remove marionette-transport dependency from DOM media tests; r?sydpolk
Attachment #8713957 -
Flags: review?(spolk)
|
||
Comment 16•8 years ago
|
||
Comment on attachment 8713957 [details] MozReview Request: Bug 1239987 - Remove marionette-transport dependency from DOM media tests; r?sydpolk https://reviewboard.mozilla.org/r/32927/#review29809 LGTM. Thanks for fixing this nit.
Attachment #8713957 -
Flags: review?(spolk) → review+
|
||
Comment 17•8 years ago
|
||
Comment on attachment 8713956 [details] MozReview Request: Bug 1239987 - Remove marionette-transport dependency from build environment; r?gps https://reviewboard.mozilla.org/r/32925/#review29887
Attachment #8713956 -
Flags: review?(gps) → review+
|
||
Comment 18•8 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/14fc79557216 https://hg.mozilla.org/integration/mozilla-inbound/rev/7b4ae617ff64 https://hg.mozilla.org/integration/mozilla-inbound/rev/9c2bd3a62358 https://hg.mozilla.org/integration/mozilla-inbound/rev/50738d8ef84b
|
||
Comment 19•8 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/14fc79557216 https://hg.mozilla.org/mozilla-central/rev/7b4ae617ff64 https://hg.mozilla.org/mozilla-central/rev/9c2bd3a62358 https://hg.mozilla.org/mozilla-central/rev/50738d8ef84b
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox47:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla47
|
||
Updated•1 year ago
|
Product: Testing → Remote Protocol
|
||
Comment 20•1 year ago
|
||
Moving bugs for Marionette client due to component changes.
Component: Marionette → Marionette Client and Harness
Product: Remote Protocol → Testing
You need to log in
before you can comment on or make changes to this bug.
Description
•