1240023 - Height of selected row is bigger than other rows

Status: NEW

(DevTools :: Memory, defect, P3)

Description

[Patrick Brosset <:pbro>]

Attachment: row-height.png

In the memory panel table, on Windows 10 (with dev-edition), the visible height of a selected row (highlighted in dark blue) is bigger than that of other rows.

Just create a snapshot on any page, and select a row in the resulting table.
The screenshot should show this pretty well.

Comment 1

[Greg Tatum [:gregtatum]]

Attachment: Font baselines differ

I'm looking into the inconsistencies in row height and font size. I'm noticing that the baseline of the fonts differ depending on the font-family. This gif shows off switching between Consolas and Segoi UI. Notice how the baselines get shifted. This is on Windows 7 FF Nightly.

There is a kind of a nasty font-size: 90% in the style that's being inherited in ( https://dxr.mozilla.org/mozilla-central/source/devtools/client/themes/memory.css#265 .) This is creating partial px sizing.

I wonder if the vertical sizing of the rows are switched to relative values instead of pixel values if some of these issues might go away, plus clear whole pixel sized font sizes. I'm worried that this tight of a row height might continue to be a bit inconsistent because of differences in the fonts themselves (which change depending on the OS.) It's a little harder to test because my dev machine is Mac, which looks correct as is.