1240044 - Intermittent browser_profiler_tree-abstract-02.js | The root node is now focused. - Got null, expected [object XULElement]

Status: RESOLVED FIXED

(DevTools :: General, defect)

Description

[Carsten Book [:Tomcat]]

https://treeherder.mozilla.org/logviewer.html#?job_id=6633045&repo=fx-team

 06:05:33 INFO - 36 INFO TEST-UNEXPECTED-FAIL | devtools/client/performance/test/browser_profiler_tree-abstract-02.js | The root node is now focused. - Got null, expected [object XULElement]

Comment 1

[Intermittent Failures Robot]

17 automation job failures were associated with this bug yesterday.

Repository breakdown:
* fx-team: 10
* try: 2
* mozilla-inbound: 2
* mozilla-central: 2
* b2g-inbound: 1

Platform breakdown:
* linux64: 17

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1240044&startday=2016-01-15&endday=2016-01-15&tree=all

Comment 2

[Intermittent Failures Robot]

17 automation job failures were associated with this bug in the last 7 days.

Repository breakdown:
* fx-team: 10
* try: 2
* mozilla-inbound: 2
* mozilla-central: 2
* b2g-inbound: 1

Platform breakdown:
* linux64: 17

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1240044&startday=2016-01-11&endday=2016-01-17&tree=all

Comment 3

[Julian Descottes [:jdescottes]]

After skipping a test in Bug 1240368, the situation improved. 

But for 24hours I have seen more and more occurrences of these focus issues and I would try to go and implement the solution proposed by Neil in Bug 1240509.

Comment 4

[Julian Descottes [:jdescottes]]

Attachment: bug1240044.v1.patch

This commit adds a helper method in performance/test/head.js to wait on MozAfterPaint. All profiler_tree-abstract test are using it to wait for a MozAfterPaint event after adding their container to the current document.

Try push : https://treeherder.mozilla.org/#/jobs?repo=try&revision=d87df8d2d5bd

Comment 5

[Mike Conley (:mconley) (:⚙️)]

FWIW, my patches in bug 1233497 seem to make this considerably worse (intermittent -> perma) on Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=9f520c334590&selectedJob=15732058

Not sure if that information is useful, but thought I'd mention it.

Comment 6

[Mike Conley (:mconley) (:⚙️)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=d501639d8d75

Comment 7

[Mike Conley (:mconley) (:⚙️)]

Try push looks good with the CPOW-outlawing patches from bug 1233497 as well.

Comment 8

[Julian Descottes [:jdescottes]]

Comment on attachment 8710461 [details] [diff] [review]
bug1240044.v1.patch

Try failures -> obsolete, remove review flag

Comment 9

[Intermittent Failures Robot]

18 automation job failures were associated with this bug yesterday.

Repository breakdown:
* fx-team: 16
* try: 2

Platform breakdown:
* linux64: 11
* linux32: 7

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1240044&startday=2016-01-21&endday=2016-01-21&tree=all

Comment 10

[Intermittent Failures Robot]

23 automation job failures were associated with this bug in the last 7 days.

Repository breakdown:
* fx-team: 19
* try: 4

Platform breakdown:
* linux64: 15
* linux32: 8

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1240044&startday=2016-01-18&endday=2016-01-24&tree=all

Comment 11

[Intermittent Failures Robot]

38 automation job failures were associated with this bug yesterday.

Repository breakdown:
* mozilla-inbound: 22
* fx-team: 10
* try: 3
* mozilla-central: 3

Platform breakdown:
* linux32: 26
* linux64: 12

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1240044&startday=2016-02-03&endday=2016-02-03&tree=all

Comment 12

[Ben Kelly [:bkelly, not reviewing]]

Julian, any luck on moving this one forward.  Its the number 2 orange at the moment.

Comment 13

[Julian Descottes [:jdescottes]]

I was hoping for a global resolution via Bug 1240509, but looks like we won't have a patch ready just yet.

I'll resubmit a fix targetting only the browser_profiler_tree-abstract* tests shortly.

Comment 14

[Julian Descottes [:jdescottes]]

Attachment: bug1240044.v2.patch

Brian, flagging you for review since you have been involved with Bug 1240509 as well. I think we should fix the browser_profiler_tree_abstract tests for now and revisit them once a global fix can land in the test harness. 

What do you think?

try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=1382ec552a02

Bug 1240044 - wait for MozAfterPaint in browser_profiler_tree_abstract tests;r=bgrins

While waiting for a fix at test harness level, added a helper waiting for MozAfterPaint
when running in e10s mode for all the browser_profiler_tree-abstract tests.

Comment 15

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/5e024441510f

Comment 16

[Intermittent Failures Robot]

150 automation job failures were associated with this bug yesterday.

Repository breakdown:
* mozilla-inbound: 89
* fx-team: 54
* try: 5
* mozilla-central: 2

Platform breakdown:
* linux64: 115
* linux32: 31
* windows7-32: 4

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1240044&startday=2016-02-04&endday=2016-02-04&tree=all

Comment 17

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/5e024441510f

Comment 18

[Intermittent Failures Robot]

206 automation job failures were associated with this bug in the last 7 days.

Repository breakdown:
* mozilla-inbound: 119
* fx-team: 69
* try: 13
* mozilla-central: 5

Platform breakdown:
* linux64: 141
* linux32: 61
* windows7-32: 4

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1240044&startday=2016-02-01&endday=2016-02-07&tree=all