1240059 - Report resource usage data even if psutil is unavailable

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Dan Minor [:dminor]]

There's no guarantee that psutil will be available on Windows. We should still report the system information derivable from the platform module along with build duration so we have some data available for Windows builds which lack psutil.

Comment 1

[Chris Manchester (limited bugmail, email directly)]

Assuming psutil is available is also a problem when imports run before the virtualenv is bootstrapped, which is the case for clobbers in automation (many central and try builds), so we're missing data for many of those builds.

Comment 2

[Chris Manchester (limited bugmail, email directly)]

Attachment: MozReview Request: Bug 1240059 - Treat psutil as optional in record_resource_usage. r=gps

Review commit: https://reviewboard.mozilla.org/r/33655/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/33655/

Comment 3

[Gregory Szorc [:gps]]

Comment on attachment 8715929 [details]
MozReview Request: Bug 1240059 - Treat psutil as optional in record_resource_usage. r=gps

https://reviewboard.mozilla.org/r/33655/#review30337

Comment 4

[(not currently active) Ted Mielczarek]

(In reply to Chris Manchester [:chmanchester] from comment #1)
> Assuming psutil is available is also a problem when imports run before the
> virtualenv is bootstrapped, which is the case for clobbers in automation
> (many central and try builds), so we're missing data for many of those
> builds.

I noticed this the other day when I tried to run `mach resource-usage` after a local clobber build on Windows. It would be nice to figure out a way to fix that.

Comment 5

[Chris Manchester (limited bugmail, email directly)]

(In reply to Ted Mielczarek [:ted.mielczarek] from comment #4)
> (In reply to Chris Manchester [:chmanchester] from comment #1)
> > Assuming psutil is available is also a problem when imports run before the
> > virtualenv is bootstrapped, which is the case for clobbers in automation
> > (many central and try builds), so we're missing data for many of those
> > builds.
> 
> I noticed this the other day when I tried to run `mach resource-usage` after
> a local clobber build on Windows. It would be nice to figure out a way to
> fix that.

This patch may help if that was in the last few weeks.

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/a0599bb3ff5c

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/a0599bb3ff5c