1240172 - Move the docker configuration scripts from external github repo into the Bugzilla code tree

Status: RESOLVED FIXED

(Bugzilla :: Bugzilla-General, enhancement)

Description

[David Lawrence [:dkl]]

As docker has become more popular for packaging of code and dependencies for running webapps, I feel like we should make the docker configuration files part of the core Bugzilla code base. Currently it resides in my personal github repo and is only maintained by me. 

If it were part of the code base, I think we would get the following benefits:

1) It would get more attention and others could help in maintaining the configuration.
2) Newcomers to Bugzilla could easily get a running Bugzilla instance up quickly.
3) With the popularity of tools such as docker-machine, you no longer need to configure your own VM software for Windows and OSX. Then have to manually install the VM OS and all of the dependencies for running Bugzilla.
4) And also take it out of my personal repo (not that I mind).

I will work on a patch for this.

dkl

Comment 1

[David Lawrence [:dkl]]

Attachment: 1240172_1.patch

Comment 2

[Frédéric Buclin]

Why are there references to cvsbin, jade, java and tex? Bugzilla uses none of them, even optionally.

Comment 3

[David Lawrence [:dkl]]

(In reply to Frédéric Buclin from comment #2)
> Why are there references to cvsbin, jade, java and tex? Bugzilla uses none
> of them, even optionally.

Good catch. This stuff is based on my generic docker config i use for lots of things. Such as testing old releases, building docs for old releases, etc. So a lot of this can be removed since the docker config will now track the branch and only need to work for the branch it is in.

New patch coming

dkl

Comment 4

[David Lawrence [:dkl]]

(In reply to Frédéric Buclin from comment #2)
> Why are there references to cvsbin, jade, java and tex? Bugzilla uses none
> of them, even optionally.

Also to clarify, java is needed for Selenium testing. I could in theory move the dependency installation to the runtests.sh script which will save space in the base image but would also increase the time slightly to run the tests in Taskcluster so not sure if it would be a win or not.

dkl

Comment 5

[David Lawrence [:dkl]]

Attachment: 1240172_2.patch

Mainly removed some unnecessary packages originally for building PDF on older releases. Converted to using rst2pdf instead of dblatex. Knocked 400M off the image size.

Comment 6

[Dylan Hardison [:dylan] (he/him)]

Comment on attachment 8710673 [details] [diff] [review]
1240172_2.patch

Review of attachment 8710673 [details] [diff] [review]:
-----------------------------------------------------------------

r=dylan

Comment 7

[Frédéric Buclin]

Comment on attachment 8710673 [details] [diff] [review]
1240172_2.patch

>+++ b/docker_files/runtests.sh

>+if [ "$TEST_SUITE" = "docs" ]; then
>+    export JADE_PUB=/usr/share/sgml
>+    export LDP_HOME=/usr/share/sgml/docbook/dsssl-stylesheets-1.79/dtds/decls
>+    cd $BUGZILLA_ROOT/docs
>+    /bin/bash /docker_files/buildbot_step "Documentation" perl makedocs.pl --with-pdf
>+    exit $?
>+fi

Bugzilla doesn't use Jade to compile its documentation for a long time. The last branch to use Jade was 4.2, which reached EOL last year. So the 2 "export" lines can go away.

Comment 8

[David Lawrence [:dkl]]

(In reply to Frédéric Buclin from comment #7)
> >+if [ "$TEST_SUITE" = "docs" ]; then
> >+    export JADE_PUB=/usr/share/sgml
> >+    export LDP_HOME=/usr/share/sgml/docbook/dsssl-stylesheets-1.79/dtds/decls
> >+    cd $BUGZILLA_ROOT/docs
> >+    /bin/bash /docker_files/buildbot_step "Documentation" perl makedocs.pl --with-pdf
> >+    exit $?
> >+fi
> 
> Bugzilla doesn't use Jade to compile its documentation for a long time. The
> last branch to use Jade was 4.2, which reached EOL last year. So the 2
> "export" lines can go away.

Thanks for the catch. Will fix on commit.

dkl

Comment 9

[David Lawrence [:dkl]]

To ssh://[e-mail]/bugzilla/bugzilla.git
   c81a842..6967405  master -> master