Closed Bug 1240212 Opened 5 years ago Closed 5 years ago

Intermittent number-disabled.html | image comparison (==), max difference: 25, number of differing pixels: 217

Categories

(Core :: Layout: Form Controls, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla47
Tracking Status
firefox45 --- fixed
firefox46 --- fixed
firefox47 --- fixed

People

(Reporter: philor, Assigned: dholbert)

References

Details

(Keywords: intermittent-failure)

Attachments

(1 file)

Somebody must have fixed whichever other GTK+3 ASan reftest regression above this we were starring this as.

https://treeherder.mozilla.org/logviewer.html#?job_id=6637713&repo=fx-team
More of the same, I presume?
Flags: needinfo?(dholbert)
Attached patch fix v1Splinter Review
Same fix we've used elsewhere.

The test is still valid; it's just testing that <input type="number" disabled> renders the same a disabled (grayed-out) textfield.  (with the spinner covered up, since that'll clearly be different vs. a textfield)

This is something we can test regardless of whether the widget is themed.
Assignee: nobody → dholbert
Status: NEW → ASSIGNED
Flags: needinfo?(dholbert)
Attachment #8711520 - Flags: review?(jfkthame)
Attachment #8711520 - Flags: review?(jfkthame) → review+
https://hg.mozilla.org/mozilla-central/rev/1b7625c90538
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla46
Target Milestone: mozilla46 → mozilla47
Whiteboard: [checkin-needed-aurora][checkin-needed-beta]
Whiteboard: [checkin-needed-aurora][checkin-needed-beta]
You need to log in before you can comment on or make changes to this bug.