1240239 - artifact builds should include the test plugins

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Dave Townsend [:mossop]]

Many test require the presence of the test plugins but "mach artifact install" doesn't install them.

These are located at bin/plugins in the tests package and need to be installed to dist/plugins in the objdir.

Comment 1

[Nick Alexander :nalexander [he/him]]

(In reply to Dave Townsend [:mossop] from comment #0)
> Many test require the presence of the test plugins but "mach artifact
> install" doesn't install them.
> 
> These are located at bin/plugins in the tests package and need to be
> installed to dist/plugins in the objdir.

Thanks, Dave!  It should be easy to add these, assuming they all go to uniform places.  (We will need to grow the ability to write to dist/plugins, unfortunately.)

Relevant code is around https://dxr.mozilla.org/mozilla-central/source/python/mozbuild/mozbuild/artifacts.py#96 and its consumers.

Comment 2

[Chris Manchester (limited bugmail, email directly)]

Attachment: MozReview Request: Bug 1240239 - Install test plugins in artifact based builds. r=nalexander

A recent change regressed this behavior -- while an artifact build runs, it
doesn't load certain "about:" pages due to missing libraries in subdirectories
of dist/bin.

Review commit: https://reviewboard.mozilla.org/r/31155/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/31155/

Comment 3

[Chris Manchester (limited bugmail, email directly)]

Attachment: MozReview Request: Bug 1240239 - Install test plugins in artifact based builds. r=nalexander

Review commit: https://reviewboard.mozilla.org/r/31157/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/31157/

Comment 4

[Chris Manchester (limited bugmail, email directly)]

Mossop, if you have an opportunity to take this for a spin, just `rm ~/.mozbuild/package-frontend/*.jar` before `./mach build` ing. I found sanity tests for the test plugins in testing/mochitest/chrome that run fine.

Nick, I took this through the usual drill on three desktop platforms, but if you could sanity test Android at some point that would be great. Thank you.

Comment 5

[Nick Alexander :nalexander [he/him]]

Comment on attachment 8708734 [details]
MozReview Request: Bug 1240239 - Install test plugins in artifact based builds. r=nalexander

I see a review request, but I don't see the unification of patterns and pattern matching I was hoping for.  I'm canceling the request 'cuz the patch doesn't appear to have been updated, and 'cuz I think you mentioned some push-to-review issues.

Comment 6

[Chris Manchester (limited bugmail, email directly)]

Comment on attachment 8708733 [details]
MozReview Request: Bug 1240239 - Install test plugins in artifact based builds. r=nalexander

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/31155/diff/1-2/

Comment 7

[Chris Manchester (limited bugmail, email directly)]

(In reply to Chris Manchester [:chmanchester] from comment #6)
> Comment on attachment 8708733 [details]
> MozReview Request: Bug 1240239 - Install test plugins in artifact based
> builds. r=nalexander
> 
> Review request updated; see interdiff:
> https://reviewboard.mozilla.org/r/31155/diff/1-2/

Note the interdiff here isn't going to make sense because the other commit landed already. This still needs testing on Android and Windows.

Comment 8

[Nick Alexander :nalexander [he/him]]

Comment on attachment 8708733 [details]
MozReview Request: Bug 1240239 - Install test plugins in artifact based builds. r=nalexander

https://reviewboard.mozilla.org/r/31155/#review28067

lgtm.

::: python/mozbuild/mozbuild/mach_commands.py:1503
(Diff revision 2)
>          def install_callback(path, file_existed, file_updated):

Comment that we're only updating the `dist/bin` manifest, please.

Comment 9

[Dave Townsend [:mossop]]

Comment on attachment 8708733 [details]
MozReview Request: Bug 1240239 - Install test plugins in artifact based builds. r=nalexander

This fixes tests for me.

Comment 10

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/8a611a2c952c

Comment 11

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/8a611a2c952c