1240260 - Annotate intentional switch fallthroughs in dom/smil/ and dom/svg/

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Chris Peterson [:cpeterson]]

Attachment: dom-svg-MOZ_FALLTHROUGH.patch

clang's -Wimplicit-fallthrough warnings (not yet enabled in mozilla-central) warn about switch cases that fall through without a break or return statement. MOZ_FALLTHROUGH (bug 1215411) is an annotation to suppress -Wimplicit-fallthrough warnings where the fallthrough is intentional.

Comment 1

[Chris Peterson [:cpeterson]]

nsSMILParserUtils.cpp:191:5 [-Wimplicit-fallthrough] unannotated fall-through between switch labels
dom/svg/SVGPathSegListSMILType.cpp:356:5 [-Wimplicit-fallthrough] unannotated fall-through between switch labels
dom/svg/SVGPathSegListSMILType.cpp:364:5 [-Wimplicit-fallthrough] unannotated fall-through between switch labels
dom/svg/SVGTransformListParser.cpp:147:5 [-Wimplicit-fallthrough] unannotated fall-through between switch labels
dom/svg/SVGTransformListParser.cpp:175:5 [-Wimplicit-fallthrough] unannotated fall-through between switch labels
dom/svg/SVGTransformListParser.cpp

Comment 2

[Daniel Holbert [:dholbert]]

Comment on attachment 8708657 [details] [diff] [review]
dom-svg-MOZ_FALLTHROUGH.patch

Review of attachment 8708657 [details] [diff] [review]:
-----------------------------------------------------------------

r=me -- thanks for the patch!

Comment 3

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/3667aeb5ab27

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/3667aeb5ab27