Closed
Bug 1240260
Opened 8 years ago
Closed 8 years ago
Annotate intentional switch fallthroughs in dom/smil/ and dom/svg/
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla46
Tracking | Status | |
---|---|---|
firefox46 | --- | fixed |
People
(Reporter: cpeterson, Assigned: cpeterson)
References
Details
Attachments
(1 file)
4.35 KB,
patch
|
dholbert
:
review+
|
Details | Diff | Splinter Review |
clang's -Wimplicit-fallthrough warnings (not yet enabled in mozilla-central) warn about switch cases that fall through without a break or return statement. MOZ_FALLTHROUGH (bug 1215411) is an annotation to suppress -Wimplicit-fallthrough warnings where the fallthrough is intentional.
Attachment #8708657 -
Flags: review?(dholbert)
Assignee | ||
Comment 1•8 years ago
|
||
nsSMILParserUtils.cpp:191:5 [-Wimplicit-fallthrough] unannotated fall-through between switch labels dom/svg/SVGPathSegListSMILType.cpp:356:5 [-Wimplicit-fallthrough] unannotated fall-through between switch labels dom/svg/SVGPathSegListSMILType.cpp:364:5 [-Wimplicit-fallthrough] unannotated fall-through between switch labels dom/svg/SVGTransformListParser.cpp:147:5 [-Wimplicit-fallthrough] unannotated fall-through between switch labels dom/svg/SVGTransformListParser.cpp:175:5 [-Wimplicit-fallthrough] unannotated fall-through between switch labels dom/svg/SVGTransformListParser.cpp
Comment 2•8 years ago
|
||
Comment on attachment 8708657 [details] [diff] [review] dom-svg-MOZ_FALLTHROUGH.patch Review of attachment 8708657 [details] [diff] [review]: ----------------------------------------------------------------- r=me -- thanks for the patch!
Attachment #8708657 -
Flags: review?(dholbert) → review+
Comment 4•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/3667aeb5ab27
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox46:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla46
Updated•4 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•