1240352 - Allow blobfree shell scripts to use proprietary-files.txt from CM

Status: RESOLVED FIXED

(Firefox OS Graveyard :: GonkIntegration, defect)

Description

[Adam Farden [:adfad666]]

The blobfree scripts assume that all blobs will be copied from a blobs.mk but actually some are copied 'properly' in Android.mk. This results in some blobs not used by the blobfree process.

Actually there are several methods a blob can be copied to $OUT so we should use the proprietary-files.txt provided by CM repos which is a list of ALL blobs extracted from a device. This is used by extract-files.sh which pulls the blobs and creates the various mk files in /vendor.

Instead of reading and processing the mk files directly we create an intermediate file in $OUT that ensures the list is in the same format no matter which type of blob list is used.

Several devices use the existing method so we default to this, and use this new method with the TARGET_DEVICE_BLOBS_CM flag.

Comment 1

[Adam Farden [:adfad666]]

Attachment: Gonk PR

Comment 2

[Adam Farden [:adfad666]]

Juan, something interesting for you.

Comment 3

[:gerard-majax]

Great! Works fine on Z3c KK port, testing on Nexus 5 L

Comment 4

[Juan Gomez [:_AtilA_] (CET/CEST)]

Yeah indeed! I've successfully created a blobfree image using this patch, thanks Adam!

Comment 5

[:gerard-majax]

Good on Nexus 5 L too!

Comment 6

[:gerard-majax]

https://github.com/mozilla-b2g/gonk-misc/commit/35dccb3127db8f39f20b985ad312d2cd44780669