Closed Bug 1240352 Opened 4 years ago Closed 4 years ago

Allow blobfree shell scripts to use proprietary-files.txt from CM

Categories

(Firefox OS Graveyard :: GonkIntegration, defect)

ARM
Gonk (Firefox OS)
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: afarden, Assigned: afarden)

References

Details

Attachments

(1 file)

49 bytes, text/x-github-pull-request
gerard-majax
: review+
Details | Review
The blobfree scripts assume that all blobs will be copied from a blobs.mk but actually some are copied 'properly' in Android.mk. This results in some blobs not used by the blobfree process.

Actually there are several methods a blob can be copied to $OUT so we should use the proprietary-files.txt provided by CM repos which is a list of ALL blobs extracted from a device. This is used by extract-files.sh which pulls the blobs and creates the various mk files in /vendor.

Instead of reading and processing the mk files directly we create an intermediate file in $OUT that ensures the list is in the same format no matter which type of blob list is used.

Several devices use the existing method so we default to this, and use this new method with the TARGET_DEVICE_BLOBS_CM flag.
Attached file Gonk PR
Attachment #8708776 - Flags: review?(lissyx+mozillians)
Assignee: nobody → afarden
Juan, something interesting for you.
Flags: needinfo?(jgomez)
Attachment #8708776 - Flags: review?(lissyx+mozillians) → review+
Great! Works fine on Z3c KK port, testing on Nexus 5 L
Yeah indeed! I've successfully created a blobfree image using this patch, thanks Adam!
Flags: needinfo?(jgomez)
Good on Nexus 5 L too!
https://github.com/mozilla-b2g/gonk-misc/commit/35dccb3127db8f39f20b985ad312d2cd44780669
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.