1240357 - Support crossOrigin attribute on image and feImage elements

Status: RESOLVED FIXED

(Core :: SVG, enhancement)

Comment 1

[Robert Longson [:longsonr]]

Attachment: WIP

Comment 2

[Robert Longson [:longsonr]]

Cam, is the SVG specification right? It says 

attribute DOMString crossOrigin;

but the html DOM in gecko (and my WIP patch) has

attribute DOMString? crossOrigin;

Comment 3

[Cameron McCormack (:heycam)]

Checking the HTML spec, it looks like it should indeed be "DOMString?".  I've updated the spec:

  https://svgwg.org/svg2-draft/embedded.html#ImageElementCrossoriginAttribute

Comment 4

[Cameron McCormack (:heycam)]

(In fact the HTML spec changed underneath us.)

Comment 5

[Robert Longson [:longsonr]]

Attachment: working patch

Comment 6

[Robert Longson [:longsonr]]

This seems to work but I don't know how to write an automated test for it. Any suggestions?

Comment 7

[Daniel Holbert [:dholbert]]

I imagine the tricky part of the automated test is the cross-origin part, right?
That's explained a bit here:
https://developer.mozilla.org/en/docs/Mochitest#How_do_I_test_issues_which_only_show_up_when_tests_are_run_across_domains.3F

I'd expect you want to write a mochitest which...
 * ...uses SVG in an iframe and snapshotWindow to see whether stuff rendered or not, like this test:
http://mxr.mozilla.org/mozilla-central/source/dom/svg/test/test_use_with_hsts.html

 * ...uses an <image> & <feImage> that point to 'example.org', which the mochitest web server will recognize and map to your source tree, like in these tests:
http://mxr.mozilla.org/mozilla-central/source/devtools/client/inspector/test/browser_inspector_navigation.js
http://mxr.mozilla.org/mozilla-central/source/devtools/client/storage/test/storage-listings.html

A few other thoughts:
 * Promises make the iframe load callbacks a bit easier to follow.  If you're not too familiar with promises, feel free to crib from my test_use_with_hsts.html test and ping me with questions. Or, traditional async callbacks shouldn't be too complex either.
 * For robustness, your SVG file (or SVG files) should include both elements (<feImage> & <image>), with the crossOrigin attribute present & not-present.

Comment 9

[Robert Longson [:longsonr]]

Attachment: 1240357.txt

Comment 10

[BugBot [:suhaib / :marco/ :calixte]]

The bug assignee is inactive on Bugzilla, so the assignee is being reset.

Comment 11

[Suhaib Mujahid [:suhaib]]

Sorry, there was a problem with the detection of inactive users. I'm reverting the change.

Comment 13

[Robert Longson [:longsonr]]

Attachment: Bug 1240357 - Support crossOrigin attribute on image and feImage elements r=emilio

Comment 14

[Robert Longson [:longsonr]]

https://treeherder.mozilla.org/jobs?repo=try&revision=cca55dc7f214333a160e5d1921791c78d72a3920

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/21dbf1f0a49a
Support crossOrigin attribute on image and feImage elements r=emilio

Comment 16

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/39470 for changes under testing/web-platform/tests

Comment 17

[Cristina Horotan [:chorotan]]

Backed out changeset 21dbf1f0a49a (Bug 1240357) for causing wpt failures at svg-image.https.sub.html

Backout: https://hg.mozilla.org/integration/autoland/rev/7379f77af5bba946fe5a641fb8a90f220d68879f

Failure push: https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=21dbf1f0a49aa83f990254a7404cf641ae3e539b&selectedTaskRun=PEapYvdASLO7lWux-mT8Ew.0

Failure log: https://treeherder.mozilla.org/logviewer?job_id=411963582&repo=autoland&lineNumber=11654

Comment 18

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Upstream PR was closed without merging

Comment 19

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2b8d11d13743
Support crossOrigin attribute on image and feImage elements r=emilio

Comment 20

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/2b8d11d13743

Comment 21

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot

Comment 22

[Brian Thomas Smith [bsmth]]

Documentation changes can be tracked in the following GitHub issue: https://github.com/mdn/content/issues/26690