Move checks of mismatched sample rate or channel numbers to AudioStream

RESOLVED FIXED in Firefox 46

Status

()

Core
Audio/Video: Playback
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: jwwang, Assigned: jwwang)

Tracking

unspecified
mozilla46
Points:
---

Firefox Tracking Flags

(firefox46 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(2 attachments)

(Assignee)

Description

2 years ago
https://hg.mozilla.org/mozilla-central/file/5644818538de2413cce52551e32b025e6c7e352e/dom/media/mediasink/DecodedAudioDataSink.cpp#l250

There are several benefits of doing this:
1. save the memory allocation in SilentChunk.
2. have a better chance for AudioStream::Downmix() to succeed when channel number is smaller than 8.
(Assignee)

Comment 1

2 years ago
try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=2cdbeb3e1f6a
Assignee: nobody → jwwang
(Assignee)

Comment 2

2 years ago
Created attachment 8710409 [details]
MozReview Request: Bug 1240420. Part 1 - move checks of mismatched sample rate or channel numbers to AudioStream. r=kinetik.

Review commit: https://reviewboard.mozilla.org/r/31745/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/31745/
Attachment #8710409 - Flags: review?(kinetik)
(Assignee)

Comment 3

2 years ago
Created attachment 8710410 [details]
MozReview Request: Bug 1240420. Part 2 - fix warnings of signed/unsigned comparison. r=kinetik.

Review commit: https://reviewboard.mozilla.org/r/31747/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/31747/
Attachment #8710410 - Flags: review?(kinetik)
Comment on attachment 8710409 [details]
MozReview Request: Bug 1240420. Part 1 - move checks of mismatched sample rate or channel numbers to AudioStream. r=kinetik.

https://reviewboard.mozilla.org/r/31745/#review28549
Attachment #8710409 - Flags: review?(kinetik) → review+
Comment on attachment 8710410 [details]
MozReview Request: Bug 1240420. Part 2 - fix warnings of signed/unsigned comparison. r=kinetik.

https://reviewboard.mozilla.org/r/31747/#review28551
Attachment #8710410 - Flags: review?(kinetik) → review+
(Assignee)

Comment 6

2 years ago
Thanks for the review!

Comment 7

2 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/52b05e612df9
https://hg.mozilla.org/integration/mozilla-inbound/rev/632c8912c742

Comment 8

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/52b05e612df9
https://hg.mozilla.org/mozilla-central/rev/632c8912c742
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox46: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla46

Updated

2 years ago
Depends on: 1245542
You need to log in before you can comment on or make changes to this bug.