Closed Bug 1240506 Opened 4 years ago Closed 4 years ago

crash in java.lang.NullPointerException: at org.mozilla.gecko.GeckoEditable$8.run(GeckoEditable.java)

Categories

(Firefox for Android :: Keyboards and IME, defect, critical)

44 Branch
Unspecified
Android
defect
Not set
critical

Tracking

()

RESOLVED FIXED
Firefox 46
Tracking Status
firefox44 + fixed
firefox45 + fixed
firefox46 --- fixed
b2g-v2.5 --- fixed
fennec 44+ ---

People

(Reporter: Margaret, Assigned: jchen)

References

Details

(Keywords: crash, regression)

Crash Data

Attachments

(2 files)

This bug was filed from the Socorro interface and is 
report bp-68b3325b-6278-47ed-9f83-614452160116.
=============================================================

This is the #6 top crasher on beta.

Looks like this listener here is null:
http://hg.mozilla.org/releases/mozilla-beta/annotate/tip/mobile/android/base/GeckoEditable.java#l982

jchen, can you help?

java.lang.NullPointerException
	at org.mozilla.gecko.GeckoEditable$8.run(GeckoEditable.java:982)
	at android.os.Handler.handleCallback(Handler.java:733)
	at android.os.Handler.dispatchMessage(Handler.java:95)
	at android.os.Looper.loop(Looper.java:136)
	at android.app.ActivityThread.main(ActivityThread.java:5426)
	at java.lang.reflect.Method.invokeNative(Native Method)
	at java.lang.reflect.Method.invoke(Method.java:515)
	at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:1268)
	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1084)
	at dalvik.system.NativeStart.main(Native Method)
Flags: needinfo?(nchen)
Yeah we should guard against it being null.
Flags: needinfo?(nchen)
It's possible for the listener to be null before nsWindow attaches to a
GeckoView or after it detaches from a GeckoView.
Attachment #8709254 - Flags: review?(esawin)
Attachment #8709254 - Flags: review?(esawin) → review+
This looks low risk, can we request uplift?
Assignee: nobody → nchen
Flags: needinfo?(nchen)
[Tracking Requested - why for this release]: This is the #3 top crasher on beta 9 right now.
Comment on attachment 8709254 [details] [diff] [review]
Check for null listener in GeckoEditable (v1)

Approval Request Comment
[Feature/regressing bug #]: bug 1236643
[User impact if declined]: possible crash on startup/shutdown
[Describe test coverage new/current, TreeHerder]: locally
[Risks and why]: small, patch only addresses the crash
[String/UUID change made/needed]: none
Flags: needinfo?(nchen)
Attachment #8709254 - Flags: approval-mozilla-aurora?
Blocks: 1236643
Status: NEW → ASSIGNED
Keywords: regression
Attached patch Patch for BetaSplinter Review
Approval Request Comment
[Feature/regressing bug #]: bug 1236643
[User impact if declined]: possible crash on startup/shutdown
[Describe test coverage new/current, TreeHerder]: locally
[Risks and why]: small, patch only addresses the crash
[String/UUID change made/needed]: none
Attachment #8709545 - Flags: review+
Attachment #8709545 - Flags: approval-mozilla-beta?
Comment on attachment 8709545 [details] [diff] [review]
Patch for Beta

Margaret and team wants us to take this fix and do a Fennec 44.0b11 as this might fix a top crash. Let's uplift to both moz-beta and moz-release.
Attachment #8709545 - Flags: approval-mozilla-release+
Attachment #8709545 - Flags: approval-mozilla-beta?
Attachment #8709545 - Flags: approval-mozilla-beta+
Comment on attachment 8709254 [details] [diff] [review]
Check for null listener in GeckoEditable (v1)

Fix a top crash, taking it.
Attachment #8709254 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
We weren't able to reproduce this issue on an affected build, on devices reported in crash-stats(Nexus 9, Samsung Galaxy S6 Edge), so we weren't able to test this fix on Firefox 44 Beta 11.
We will have to wait for data from crash stats to verify this as fixed.
https://hg.mozilla.org/mozilla-central/rev/990d9231be8d
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 46
tracking-fennec: ? → 44+
Version: unspecified → 44 Branch
You need to log in before you can comment on or make changes to this bug.