1240506 - crash in java.lang.NullPointerException: at org.mozilla.gecko.GeckoEditable$8.run(GeckoEditable.java)

Status: RESOLVED FIXED

(Firefox for Android :: Keyboards and IME, defect, critical)

Description

[:Margaret Leibovic]

This bug was filed from the Socorro interface and is 
report bp-68b3325b-6278-47ed-9f83-614452160116.
=============================================================

This is the #6 top crasher on beta.

Looks like this listener here is null:
http://hg.mozilla.org/releases/mozilla-beta/annotate/tip/mobile/android/base/GeckoEditable.java#l982

jchen, can you help?

java.lang.NullPointerException
	at org.mozilla.gecko.GeckoEditable$8.run(GeckoEditable.java:982)
	at android.os.Handler.handleCallback(Handler.java:733)
	at android.os.Handler.dispatchMessage(Handler.java:95)
	at android.os.Looper.loop(Looper.java:136)
	at android.app.ActivityThread.main(ActivityThread.java:5426)
	at java.lang.reflect.Method.invokeNative(Native Method)
	at java.lang.reflect.Method.invoke(Method.java:515)
	at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:1268)
	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1084)
	at dalvik.system.NativeStart.main(Native Method)

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

Should we also worry about this mListener use in a runnable?
http://mxr.mozilla.org/mozilla-central/source/mobile/android/base/java/org/mozilla/gecko/GeckoEditable.java#950

Comment 2

[(inactive) Jim Chen [:jchen] [:darchons]]

Yeah we should guard against it being null.

Comment 3

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: Check for null listener in GeckoEditable (v1)

It's possible for the listener to be null before nsWindow attaches to a
GeckoView or after it detaches from a GeckoView.

Comment 4

[:Margaret Leibovic]

This looks low risk, can we request uplift?

Comment 5

[:Margaret Leibovic]

[Tracking Requested - why for this release]: This is the #3 top crasher on beta 9 right now.

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/990d9231be8d

Comment 7

[(inactive) Jim Chen [:jchen] [:darchons]]

Comment on attachment 8709254 [details] [diff] [review]
Check for null listener in GeckoEditable (v1)

Approval Request Comment
[Feature/regressing bug #]: bug 1236643
[User impact if declined]: possible crash on startup/shutdown
[Describe test coverage new/current, TreeHerder]: locally
[Risks and why]: small, patch only addresses the crash
[String/UUID change made/needed]: none

Comment 8

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: Patch for Beta

Approval Request Comment
[Feature/regressing bug #]: bug 1236643
[User impact if declined]: possible crash on startup/shutdown
[Describe test coverage new/current, TreeHerder]: locally
[Risks and why]: small, patch only addresses the crash
[String/UUID change made/needed]: none

Comment 9

[Ritu Kothari (:ritu)]

Comment on attachment 8709545 [details] [diff] [review]
Patch for Beta

Margaret and team wants us to take this fix and do a Fennec 44.0b11 as this might fix a top crash. Let's uplift to both moz-beta and moz-release.

Comment 10

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/releases/mozilla-beta/rev/afeda02c5038

Comment 11

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/releases/mozilla-release/rev/8c4d1418cc7e

Comment 12

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8709254 [details] [diff] [review]
Check for null listener in GeckoEditable (v1)

Fix a top crash, taking it.

Comment 13

[u421692]

We weren't able to reproduce this issue on an affected build, on devices reported in crash-stats(Nexus 9, Samsung Galaxy S6 Edge), so we weren't able to test this fix on Firefox 44 Beta 11.
We will have to wait for data from crash stats to verify this as fixed.

Comment 14

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/990d9231be8d

Comment 15

[Carsten Book [:Tomcat]]

 https://hg.mozilla.org/releases/mozilla-aurora/rev/304f4a86c310

Comment 16

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/afeda02c5038