Closed
Bug 1240506
Opened 6 years ago
Closed 6 years ago
crash in java.lang.NullPointerException: at org.mozilla.gecko.GeckoEditable$8.run(GeckoEditable.java)
Categories
(Firefox for Android Graveyard :: Keyboards and IME, defect)
Tracking
(firefox44+ fixed, firefox45+ fixed, firefox46 fixed, b2g-v2.5 fixed, fennec44+)
RESOLVED
FIXED
Firefox 46
People
(Reporter: Margaret, Assigned: jchen)
References
Details
(Keywords: crash, regression)
Crash Data
Attachments
(2 files)
3.46 KB,
patch
|
esawin
:
review+
Sylvestre
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
3.41 KB,
patch
|
jchen
:
review+
ritu
:
approval-mozilla-beta+
ritu
:
approval-mozilla-release+
|
Details | Diff | Splinter Review |
This bug was filed from the Socorro interface and is report bp-68b3325b-6278-47ed-9f83-614452160116. ============================================================= This is the #6 top crasher on beta. Looks like this listener here is null: http://hg.mozilla.org/releases/mozilla-beta/annotate/tip/mobile/android/base/GeckoEditable.java#l982 jchen, can you help? java.lang.NullPointerException at org.mozilla.gecko.GeckoEditable$8.run(GeckoEditable.java:982) at android.os.Handler.handleCallback(Handler.java:733) at android.os.Handler.dispatchMessage(Handler.java:95) at android.os.Looper.loop(Looper.java:136) at android.app.ActivityThread.main(ActivityThread.java:5426) at java.lang.reflect.Method.invokeNative(Native Method) at java.lang.reflect.Method.invoke(Method.java:515) at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:1268) at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1084) at dalvik.system.NativeStart.main(Native Method)
Flags: needinfo?(nchen)
Comment 1•6 years ago
|
||
Should we also worry about this mListener use in a runnable? http://mxr.mozilla.org/mozilla-central/source/mobile/android/base/java/org/mozilla/gecko/GeckoEditable.java#950
Assignee | ||
Comment 3•6 years ago
|
||
It's possible for the listener to be null before nsWindow attaches to a GeckoView or after it detaches from a GeckoView.
Attachment #8709254 -
Flags: review?(esawin)
Updated•6 years ago
|
Attachment #8709254 -
Flags: review?(esawin) → review+
Reporter | ||
Comment 4•6 years ago
|
||
This looks low risk, can we request uplift?
Assignee: nobody → nchen
Flags: needinfo?(nchen)
Reporter | ||
Comment 5•6 years ago
|
||
[Tracking Requested - why for this release]: This is the #3 top crasher on beta 9 right now.
tracking-firefox44:
--- → ?
tracking-firefox45:
--- → ?
Assignee | ||
Comment 7•6 years ago
|
||
Comment on attachment 8709254 [details] [diff] [review] Check for null listener in GeckoEditable (v1) Approval Request Comment [Feature/regressing bug #]: bug 1236643 [User impact if declined]: possible crash on startup/shutdown [Describe test coverage new/current, TreeHerder]: locally [Risks and why]: small, patch only addresses the crash [String/UUID change made/needed]: none
Flags: needinfo?(nchen)
Attachment #8709254 -
Flags: approval-mozilla-aurora?
Assignee | ||
Updated•6 years ago
|
Assignee | ||
Comment 8•6 years ago
|
||
Approval Request Comment [Feature/regressing bug #]: bug 1236643 [User impact if declined]: possible crash on startup/shutdown [Describe test coverage new/current, TreeHerder]: locally [Risks and why]: small, patch only addresses the crash [String/UUID change made/needed]: none
Attachment #8709545 -
Flags: review+
Attachment #8709545 -
Flags: approval-mozilla-beta?
Comment on attachment 8709545 [details] [diff] [review] Patch for Beta Margaret and team wants us to take this fix and do a Fennec 44.0b11 as this might fix a top crash. Let's uplift to both moz-beta and moz-release.
Attachment #8709545 -
Flags: approval-mozilla-release+
Attachment #8709545 -
Flags: approval-mozilla-beta?
Attachment #8709545 -
Flags: approval-mozilla-beta+
Comment 10•6 years ago
|
||
bugherderuplift |
https://hg.mozilla.org/releases/mozilla-beta/rev/afeda02c5038
Comment 12•6 years ago
|
||
Comment on attachment 8709254 [details] [diff] [review] Check for null listener in GeckoEditable (v1) Fix a top crash, taking it.
Attachment #8709254 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Updated•6 years ago
|
Comment 13•6 years ago
|
||
We weren't able to reproduce this issue on an affected build, on devices reported in crash-stats(Nexus 9, Samsung Galaxy S6 Edge), so we weren't able to test this fix on Firefox 44 Beta 11. We will have to wait for data from crash stats to verify this as fixed.
Comment 14•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/990d9231be8d
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox46:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 46
Comment 16•6 years ago
|
||
bugherderuplift |
https://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/afeda02c5038
status-b2g-v2.5:
--- → fixed
Updated•6 years ago
|
tracking-fennec: ? → 44+
Updated•6 years ago
|
Version: unspecified → 44 Branch
Updated•1 year ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•