1240539 - Populate WidgetEvent's timeStamp with data from NSEvent.timeStamp

Status: RESOLVED FIXED

(Core :: Widget: Cocoa, defect, P3)

Description

[Chris H-C :chutten]

To assist with measurement efforts like bug 1235908, we should populate generated WidgetEvents with the event creation timeStamp provided by the underlying system (in cocoa's case, NSEvent's timeStamp).

See widget/gtk/nsWindow::GetEventTimeStamp and widget/windows/nsWindow::InitEvent for how this has been done for Linux, Windows.

Comment 1

[Jim Mathies [:jimm]]

Is there an active need for this or is this just, we'd like to have it at some point?

Comment 2

[Chris H-C :chutten]

This is "We currently do not get data from Mac users for the measure INPUT_EVENT_RESPONSE_MS and cannot until this is fixed". So, I guess it depends on how much we value data from Mac users?

From my POV, Mac users are such a small proportion of our user base, it doesn't need to be rushed. talos' tp5o_responsiveness covers platform-specific regressions in ui event handling decently well (for parent processes).

Comment 3

[Josh Aas]

I doubt this request is relevant any more but I'll take it as an opportunity to audit that we're setting times correctly on all events.

Most events already have times set properly but there are a few gaps to fix up.

Comment 4

[Josh Aas]

Attachment: Bug 1240539 - Add timestamps to some Gecko events sent by Cocoa widgets that didn't already have timestamps set. r?#mac-reviewers

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/e5fe445e17c6
https://hg.mozilla.org/integration/autoland/rev/bbf757970181
Add timestamps to some Gecko events sent by Cocoa widgets that didn't already have timestamps set. r=mac-reviewers,bradwerth

Comment 6

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/bbf757970181