Closed Bug 1240607 Opened 5 years ago Closed 5 years ago
Window interception to be a detour
It looks like we have imperfect detection of Optimus DLL injection under bug 1218473. Until I find out why that is the case, I think we should force the CreateWindowExW interception to be a detour. This will definitively prevent further crashes even if the Optimus detection fails.
Actually this is IPC
Component: Plug-ins → IPC
Summary: Force CreateWindowExW interception to be a detour → Force CreateWindow interception to be a detour
[Tracking Requested - why for this release]: this might be needed as addition to fix the nasty nvidia optimus crash in bug 1218473 for good, see https://bugzilla.mozilla.org/show_bug.cgi?id=1218473#c81. this is making up over 5% of crashes in rc1 atm, after it had already gone away in 44 beta 8 & 9.
Comment on attachment 8709166 [details] [diff] [review] Patch Approval Request Comment [Feature/regressing bug #]: bug 1213567 + NVidia Optimus Drivers [User impact if declined]: Crashes [Describe test coverage new/current, TreeHerder]: Existing tests will cover this [Risks and why]: Low. well understood problem, simple solution [String/UUID change made/needed]: None.
Comment on attachment 8709166 [details] [diff] [review] Patch Aaron believes this is a safe fix, we've already made this change in other places, so should be a very low risk uplift. Taking it in Fx44 RC2.
Attachment #8709166 - Flags: approval-mozilla-beta? → approval-mozilla-release+
Comment on attachment 8709166 [details] [diff] [review] Patch Fix a crash, taking it.
Attachment #8709166 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
You need to log in before you can comment on or make changes to this bug.