1240610 - --jsdebugger flag is broken

Status: RESOLVED FIXED

(Testing :: Marionette Client and Harness, defect)

Description

[Andreas Tolfsen ❲:ato❳]

The --jsdebugger flag to the `./mach marionette-test` command is broken:

% ./mach marionette-test -vv --jsdebugger --gecko-log -
 0:00.00 LOG: MainThread INFO Using workspace for temporary data: "/home/ato/1/gecko/src"
 0:00.00 LOG: MainThread INFO Profile destination is TMP
1453151571582	Marionette	DEBUG	Marionette enabled via build flag and pref
1453151571793	Marionette	INFO	Listening on port 2828
1453151572030	Marionette	DEBUG	Marionette enabled via command-line flag
1453151572062	Marionette	INFO	MarionetteServer#driverFactory
1453151572063	Marionette	INFO	Accepted connection conn0 from 127.0.0.1:42574
 0:00.98 LOG: MainThread ERROR Failure during test execution.
Traceback (most recent call last):

  File "/home/ato/1/gecko/src/testing/marionette/client/marionette/runtests.py", line 71, in run
    runner.run_tests(tests)

  File "/home/ato/1/gecko/src/testing/marionette/client/marionette/runner/base.py", line 819, in run_tests
    self.capabilities

  File "/home/ato/1/gecko/src/testing/marionette/client/marionette/runner/base.py", line 652, in capabilities
    self.marionette.start_session()

  File "/home/ato/1/gecko/src/testing/marionette/driver/marionette_driver/marionette.py", line 1183, in start_session
    self.protocol, _ = self.client.connect()

  File "/home/ato/1/gecko/src/testing/marionette/transport/marionette_transport/transport.py", line 219, in connect
    raw = self.receive(unmarshal=False)

  File "/home/ato/1/gecko/src/testing/marionette/transport/marionette_transport/transport.py", line 199, in receive
    raise socket.timeout("connection timed out after %ds" % self.socket_timeout)

TypeError: %d format: a number is required, not NoneType

Error running mach:

    ['marionette-test', '-vv', '--jsdebugger', '--gecko-log', '-']

The error occurred in code that was called by the mach command. This is either
a bug in the called code itself or in the way that mach is calling it.

You should consider filing a bug for this issue.

If filing a bug, please include the full output of mach, including this error
message.

The details of the failure are as follows:

TypeError: %d format: a number is required, not NoneType

  File "/home/ato/1/gecko/src/testing/marionette/mach_commands.py", line 119, in run_marionette_test
    return run_marionette(tests, topsrcdir=self.topsrcdir, **kwargs)
  File "/home/ato/1/gecko/src/testing/marionette/mach_commands.py", line 70, in run_marionette
    failed = MarionetteHarness(MarionetteTestRunner, args=args).run()
  File "/home/ato/1/gecko/src/testing/marionette/client/marionette/runtests.py", line 71, in run
    runner.run_tests(tests)
  File "/home/ato/1/gecko/src/testing/marionette/client/marionette/runner/base.py", line 819, in run_tests
    self.capabilities
  File "/home/ato/1/gecko/src/testing/marionette/client/marionette/runner/base.py", line 652, in capabilities
    self.marionette.start_session()
  File "/home/ato/1/gecko/src/testing/marionette/driver/marionette_driver/marionette.py", line 1183, in start_session
    self.protocol, _ = self.client.connect()
  File "/home/ato/1/gecko/src/testing/marionette/transport/marionette_transport/transport.py", line 219, in connect
    raw = self.receive(unmarshal=False)
  File "/home/ato/1/gecko/src/testing/marionette/transport/marionette_transport/transport.py", line 199, in receive
    raise socket.timeout("connection timed out after %ds" % self.socket_timeout)

Comment 1

[Andreas Tolfsen ❲:ato❳]

Attachment: MozReview Request: Bug 1240610 - Align socket_timeout with Python's socket interface; r?automatedtester

When socket.settimeout(None) is set in Python's standard library this
is meant to be equivalent to disabling timeouts on socket operations.
marionette.transport should respect this.

This change set unbreaks the use of the --jdebugger flag to `./mach
marionette-test'.

Review commit: https://reviewboard.mozilla.org/r/31443/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/31443/

Comment 2

[David Burns :automatedtester]

Comment on attachment 8709439 [details]
MozReview Request: Bug 1240610 - Align socket_timeout with Python's socket interface; r?automatedtester

https://reviewboard.mozilla.org/r/31443/#review28193

Comment 3

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/481a3c76e313

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

I had to back this out for b2g xpcshell failures like https://treeherder.mozilla.org/logviewer.html#?job_id=20081356&repo=mozilla-inbound
https://hg.mozilla.org/integration/mozilla-inbound/rev/848ae0f4b10a

Comment 5

[Andreas Tolfsen ❲:ato❳]

Comment on attachment 8709439 [details]
MozReview Request: Bug 1240610 - Align socket_timeout with Python's socket interface; r?automatedtester

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/31443/diff/1-2/

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/78fabaaedeb1

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/78fabaaedeb1

Comment 8

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Moving bugs for Marionette client due to component changes.