1240620 - index-db.js in SDK needs to pass the proper origin attributes to createCodebasePrincipal

Status: RESOLVED WONTFIX

(Add-on SDK Graveyard :: General, defect)

Description

[Dave Huseby [:huseby]]

in the file addon-sdk/source/lib/sdk/indexed-db.js there's a call to createCodebasePrincipal that needs to be changed to use an origin attribute with the default user context id when creating the principal.

Comment 1

[Dave Huseby [:huseby]]

Matteo,

I am in the process of fixing up all of the uses of createCodebasePrincipal so that we have the proper origin attributes set on all of the principals we use.  Dan Veditz suggested I confirm with you that we're deprecating the add-ons API before fixing the call site in addon-sdk/source/lib/sdk/indexed-db.js.

Is that true?  Or should I fix this code up?

Comment 2

[Matteo Ferretti [:zer0] [:matteo]]

(In reply to Dave Huseby [:huseby] from comment #1)

> I am in the process of fixing up all of the uses of createCodebasePrincipal
> so that we have the proper origin attributes set on all of the principals we
> use.  Dan Veditz suggested I confirm with you that we're deprecating the
> add-ons API before fixing the call site in
> addon-sdk/source/lib/sdk/indexed-db.js.

> Is that true?  Or should I fix this code up?

Hi Dave, sorry for my late response. It is true that currently there is not active work on SDK APIs, but they're still maintained; so my guess is that this code should be fixed too.

Comment 3

[Jonathan Hao (inactive) [:jhao]]

Tim gave me his permission to take this bug from him :D

Comment 4

[Jonathan Hao (inactive) [:jhao]]

I tried to import ChromeUtils but couldn't. Dave said that we can't use ChromeUtils in addon-sdk, and this bug should probably be "resolved won't fix."

Comment 5

[Dave Huseby [:huseby]]

Yes, this bug needs to be resolved as won't fix.  Ideally, this call would propagate the add-on ID in the origin attributes but since we're no longer maintaining the SDK due to the transition to WebExtensions, I think the right thing is to just leave it as-is.