Closed Bug 1240662 Opened 4 years ago Closed 4 years ago

Pass WebGL2 conformance test framebuffer-texture-layer

Categories

(Core :: Canvas: WebGL, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla46
Tracking Status
firefox46 --- fixed

People

(Reporter: mtseng, Assigned: mtseng)

References

()

Details

Attachments

(1 file, 1 obsolete file)

No description provided.
Status: NEW → ASSIGNED
Blocks: 1240673
Comment on attachment 8709279 [details] [diff] [review]
Add max level check for framebufferTextureLayer.

Review of attachment 8709279 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/canvas/WebGL2ContextFramebuffers.cpp
@@ +298,5 @@
>  
> +        if (level < 0)
> +            return ErrorInvalidValue("framebufferTextureLayer: level must be >= 0.");
> +
> +        const auto fnFloorPOT = [](uint32_t& val) {

Use FloorLog2() from mfbt/MathAlgorithms.h.
Attachment #8709279 - Flags: review?(jgilbert) → review-
Address Jeff's comment.
Attachment #8709823 - Flags: review?(jgilbert)
Attachment #8709279 - Attachment is obsolete: true
Attachment #8709823 - Flags: review?(jgilbert) → review+
https://hg.mozilla.org/mozilla-central/rev/235d8796a279
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla46
You need to log in before you can comment on or make changes to this bug.