Closed
Bug 1240662
Opened 9 years ago
Closed 9 years ago
Pass WebGL2 conformance test framebuffer-texture-layer
Categories
(Core :: Graphics: CanvasWebGL, defect)
Core
Graphics: CanvasWebGL
Tracking
()
RESOLVED
FIXED
mozilla46
Tracking | Status | |
---|---|---|
firefox46 | --- | fixed |
People
(Reporter: mtseng, Assigned: mtseng)
References
()
Details
Attachments
(1 file, 1 obsolete file)
2.91 KB,
patch
|
jgilbert
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Comment 1•9 years ago
|
||
Attachment #8709279 -
Flags: review?(jgilbert)
Assignee | ||
Updated•9 years ago
|
Status: NEW → ASSIGNED
Comment 2•9 years ago
|
||
Comment on attachment 8709279 [details] [diff] [review] Add max level check for framebufferTextureLayer. Review of attachment 8709279 [details] [diff] [review]: ----------------------------------------------------------------- ::: dom/canvas/WebGL2ContextFramebuffers.cpp @@ +298,5 @@ > > + if (level < 0) > + return ErrorInvalidValue("framebufferTextureLayer: level must be >= 0."); > + > + const auto fnFloorPOT = [](uint32_t& val) { Use FloorLog2() from mfbt/MathAlgorithms.h.
Attachment #8709279 -
Flags: review?(jgilbert) → review-
Assignee | ||
Comment 3•9 years ago
|
||
Address Jeff's comment.
Attachment #8709823 -
Flags: review?(jgilbert)
Assignee | ||
Updated•9 years ago
|
Attachment #8709279 -
Attachment is obsolete: true
Updated•9 years ago
|
Attachment #8709823 -
Flags: review?(jgilbert) → review+
Assignee | ||
Comment 4•9 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=1511e9ff3502
Comment 6•9 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/235d8796a279
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox46:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla46
You need to log in
before you can comment on or make changes to this bug.
Description
•