1240670 - Hide the filter property search for an unmatched rule

Status: RESOLVED FIXED

(DevTools :: Inspector: Rules, defect)

Description

[Gabriel Luong [:gl] (ΦωΦ)]

The filter property search should be hidden when a rule does not match the currently selected rule. 

STR:
1. Edit selector to a selector that doesn't match the current element
2. Assuming there is a property that is overridden in the new rule created, see the filter property search appears

Comment 1

[Gabriel Luong [:gl] (ΦωΦ)]

Attachment: 1240670.patch

Comment 2

[Patrick Brosset <:pbro>]

Comment on attachment 8709301 [details] [diff] [review]
1240670.patch

Review of attachment 8709301 [details] [diff] [review]:
-----------------------------------------------------------------

This looks good to me.

Comment 3

[Gabriel Luong [:gl] (ΦωΦ)]

Attachment: 1240670.patch [1.0]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=12f510482506

Comment 4

[Patrick Brosset <:pbro>]

Comment on attachment 8709850 [details] [diff] [review]
1240670.patch [1.0]

Review of attachment 8709850 [details] [diff] [review]:
-----------------------------------------------------------------

::: devtools/client/inspector/rules/views/rule-editor.js
@@ +494,5 @@
>          ruleView.emit("ruleview-invalid-selector");
>          return;
>        }
>  
> +      ruleProps.isUnmatched = !isMatching;

I don't feel too strongly about this, but it might be cleaner to do this in the Front class instead.
I can imagine someone reading through this code for the first time thinking:

"'this.rule.domRule.modifySelector' is a server request that returns a ruleProps object that's really useful, and I can see it contains things like 'isSystem'. So why is 'isUnmatched' not already a property of ruleProps? Why is it sent separately and why do I have have to set it manually upon receiving the response?"

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/39b3a8406296

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/39b3a8406296