Closed
Bug 1240678
Opened 9 years ago
Closed 9 years ago
Running email build.js on node.js
Categories
(Firefox OS Graveyard :: Gaia::Build, defect, P1)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: rickychien, Assigned: rickychien)
References
Details
Attachments
(1 file)
Refactor apps/email/build/build.js to node.js
|
Assignee | |
Updated•9 years ago
|
Priority: -- → P1
|
||
Comment 1•9 years ago
|
||
|
|
Assignee | |
Comment 2•9 years ago
|
||
Comment on attachment 8712704 [details] [review]
[gaia] rickychien:email-build-to-node > mozilla-b2g:master
Scott, finally I found out problem in getParse() and optimize() within Promise.all() and modified their order so that it passed on node.js build.
However, I have no idea why it breaks our build but it should be functioning properly now.
Attachment #8712704 -
Flags: review?(scwwu)
|
|
Assignee | |
Comment 3•9 years ago
|
||
./node-build-diff.sh seems good to my eyes but please do me a favor to take a look at it carefully. thanks!
|
||
Comment 4•9 years ago
|
||
Comment on attachment 8712704 [details] [review]
[gaia] rickychien:email-build-to-node > mozilla-b2g:master
Diff looks good to me too. Thanks!
r+
Attachment #8712704 -
Flags: review?(scwwu) → review+
|
|
Assignee | |
Comment 5•9 years ago
|
||
Landed in master:
https://github.com/mozilla-b2g/gaia/commit/6c1a8328b3ae5d4b02308fae14a3966dfd732c80
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•