Closed
Bug 1240699
Opened 8 years ago
Closed 8 years ago
Abstract mock injection and move mock_navigator_moz_icc_manager.js from SMS to shared
Categories
(Firefox OS Graveyard :: Gaia::Shared, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: jlorenzo, Assigned: jlorenzo)
References
Details
Attachments
(1 file)
In bug 1232680, Dialer will require mock_navigator_moz_icc_manager.js. We can also make the test more agnostic about how a mock in injected. For example: Is the mock supposed to be in the shared or not?
|
||
Comment 1•8 years ago
|
||
|
Assignee | |
Updated•8 years ago
|
Assignee: nobody → jlorenzo
|
|
Assignee | |
Updated•8 years ago
|
Attachment #8709360 -
Flags: review?(azasypkin)
|
||
Comment 2•8 years ago
|
||
Comment on attachment 8709360 [details] [review] [gaia] JohanLorenzo:bug-1240699 > mozilla-b2g:master I like it :) I have run messages tests locally (to include currently disabled tests) and everything was green. So, ship it! Thanks!
Attachment #8709360 -
Flags: review?(azasypkin) → review+
|
|
Assignee | |
Comment 3•8 years ago
|
||
It was also green on Treeherder. Landed in master at: https://github.com/mozilla-b2g/gaia/commit/e3aa3c0b04df0d7db654ccf3fee2d4342600d668
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Comment 4•8 years ago
|
||
(In reply to Johan Lorenzo [:jlorenzo] (QA) from comment #3) My apologies if somebody sees this message, I realized I forgot to squash my commits before landing it.
You need to log in
before you can comment on or make changes to this bug.
Description
•