These members are later properly set in EnsureInitialized which is called before any method that reads them, but there's no reason to leave them uninitialized in the constructor considering the annoying warning noise that it generates, and if a bug is introduced it'll be much easier to debug if we dereference nullptr than some random address.
Assignee: nobody → nical.bugzilla
Whiteboard: [CID 749989]
Created attachment 8709414 [details] [diff] [review] Don't leave uninitialized after in GLXLibrary's ctor
Created attachment 8709421 [details] [diff] [review] Don't leave uninitialized members after GLXLibrary's ctor Previously uploaded the wrong version of the patch.
Created attachment 8709458 [details] [diff] [review] While we are at it, do it for EGL symbols.
Attachment #8709458 - Flags: review?(matt.woodrow)
Whiteboard: [CID 749989] → [CID 749989][CID 1123714]
Attachment #8709421 - Flags: review?(matt.woodrow) → review+
Attachment #8709458 - Flags: review?(matt.woodrow) → review+
Status: NEW → RESOLVED
Last Resolved: 3 years ago
status-firefox46: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla46
You need to log in before you can comment on or make changes to this bug.