Closed Bug 1240730 Opened 4 years ago Closed 4 years ago

Initialize all GLXLibrary symbols in the ctor to silence static analysis warnings

Categories

(Core :: Graphics, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla46
Tracking Status
firefox46 --- fixed

People

(Reporter: nical, Assigned: nical)

References

(Blocks 1 open bug)

Details

(Keywords: coverity, Whiteboard: [CID 749989][CID 1123714])

Attachments

(2 files, 1 obsolete file)

These members are later properly set in EnsureInitialized which is called before any method that reads them, but there's no reason to leave them uninitialized in the constructor considering the annoying warning noise that it generates, and if a bug is introduced it'll be much easier to debug if we dereference nullptr than some random address.
Assignee: nobody → nical.bugzilla
Keywords: coverity
Whiteboard: [CID 749989]
Attachment #8709414 - Flags: review?(matt.woodrow)
Previously uploaded the wrong version of the patch.
Attachment #8709414 - Attachment is obsolete: true
Attachment #8709414 - Flags: review?(matt.woodrow)
Attachment #8709421 - Flags: review?(matt.woodrow)
Attachment #8709458 - Flags: review?(matt.woodrow)
Whiteboard: [CID 749989] → [CID 749989][CID 1123714]
Attachment #8709421 - Flags: review?(matt.woodrow) → review+
Attachment #8709458 - Flags: review?(matt.woodrow) → review+
https://hg.mozilla.org/mozilla-central/rev/c940c4d4b17e
https://hg.mozilla.org/mozilla-central/rev/75104f84eda6
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla46
You need to log in before you can comment on or make changes to this bug.