1240740 - Running all app's build.js on node.js

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Build, defect, P1)

Description

[Ricky Chien [:rickychien] (inactive)]

This bug is using for refactoring / ensuring all app's build script (system/build/build.js, settings/build/build.js, gallery/build/build.js...etc) are able to run on node.js environment.

Comment 1

[GitHub Autolander Bot]

Attachment: [gaia] rickychien:all-apps-build-to-node > mozilla-b2g:master

Comment 2

[Ricky Chien [:rickychien] (inactive)]

Comment on attachment 8711552 [details] [review]
[gaia] rickychien:all-apps-build-to-node > mozilla-b2g:master

Hey, here is a big piece of changes for fixing almost all app's build.js. For those apps who are using specific XPConnect APIs (email, keyboard, operatorvariant), we don't port them in this time.

Some of dirty code you might see but they will be cleaned up as long as our first step migration is complete. For instance, module system is different between xlc and node. require() call's loader rules are different so I fixed that with moving out libraries with some of hacks temporary.

There might be other problem or uneasy understand part to you, please ask any questions if you're unsure :)

Comment 3

[Scott Wu [:scottwu]]

Comment on attachment 8711552 [details] [review]
[gaia] rickychien:all-apps-build-to-node > mozilla-b2g:master

Tested on device and diff looks good. r+
Thanks

Comment 4

[Ricky Chien [:rickychien] (inactive)]

Landed in master:

https://github.com/mozilla-b2g/gaia/commit/1281a7711822e5c668a22190ae55781154d6062d

Comment 5

[GitHub Autolander Bot]

Attachment: [gaia] mozilla-b2g:revert-33944-all-apps-build-to-node > mozilla-b2g:master

Comment 6

[Ricky Chien [:rickychien] (inactive)]

Revert https://github.com/mozilla-b2g/gaia/commit/a2ed4f70825dd3591b910060e37e1d7f78c36c6a
since it breaks RUN_ON_NODE=1 for throwing escodegen is not defined

Comment 7

[GitHub Autolander Bot]

Attachment: [gaia] rickychien:all-apps-build-to-node > mozilla-b2g:master

Comment 8

[Ricky Chien [:rickychien] (inactive)]

Fixed and landed in master again.

https://github.com/mozilla-b2g/gaia/commit/76ca5783d9ad578d2b09920d5eee87e6b6b39803