1240762 - Service worker request coming from Cache are not correctly displayed

Status: RESOLVED FIXED

(DevTools :: Netmonitor, defect)

Description

[Alexandre Poirot [:ochameau]]

Intercepted request coming from Cache ends up having a broken display in the netmonitor.

You can try opening this example:
  https://boopathi.in/sw-cache-all/
When reloading, the request being hooked by the service worker are not flagged correctly, nor can we see their response content.

We can't see the content of the requests because of this exception:
NS_ERROR_INVALID_CONTENT_ENCODING: Component returned failure code: 0x804b001b (NS_ERROR_INVALID_CONTENT_ENCODING) [nsIStreamListener.onDataAvailable]

We get this exception as we try to apply the compression converter here:
  http://mxr.mozilla.org/mozilla-central/source/devtools/shared/webconsole/network-monitor.js#223
Which is a hack specific to e10s, with request going to the parent.
In current service worker codepath, request stay in the child and are not gzipped. We don't need this converter workaround.

Also, we end up missing updating "saveRequestAndResponseBodies" on pref change when we instanciate this NetworkMonitor instance in the child process.

Comment 1

[Alexandre Poirot [:ochameau]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=ec4c98e7ac3a

Comment 2

[Alexandre Poirot [:ochameau]]

Attachment: patch v1

See comment 0 for more info about this patch.
Feel free to redirect the review to whoever would be best looking at that.

Comment 3

[Victor Porof [:vporof][:vp]]

Comment on attachment 8709956 [details] [diff] [review]
patch v1

Review of attachment 8709956 [details] [diff] [review]:
-----------------------------------------------------------------

Do we want to temporarily just omit these requests or have them displayed in the netmonitor at some point?

Comment 4

[Alexandre Poirot [:ochameau]]

These requests (Cache/ServiceWorker/Fetch) are already displayed, but with stuff being incorrect or broken (transfered size empty, and empty response content panel).

Comment 5

[Alexandre Poirot [:ochameau]]

https://hg.mozilla.org/integration/fx-team/rev/afb7e27d06f569b5dbc6d477ce09135101fd5097
Bug 1240762 - Fix ServiceWorker request coming from Cache/Fetch. r=vporof

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/afb7e27d06f5