Closed Bug 1240762 Opened 5 years ago Closed 5 years ago
Service worker request coming from Cache are not correctly displayed
Intercepted request coming from Cache ends up having a broken display in the netmonitor. You can try opening this example: https://boopathi.in/sw-cache-all/ When reloading, the request being hooked by the service worker are not flagged correctly, nor can we see their response content. We can't see the content of the requests because of this exception: NS_ERROR_INVALID_CONTENT_ENCODING: Component returned failure code: 0x804b001b (NS_ERROR_INVALID_CONTENT_ENCODING) [nsIStreamListener.onDataAvailable] We get this exception as we try to apply the compression converter here: http://mxr.mozilla.org/mozilla-central/source/devtools/shared/webconsole/network-monitor.js#223 Which is a hack specific to e10s, with request going to the parent. In current service worker codepath, request stay in the child and are not gzipped. We don't need this converter workaround. Also, we end up missing updating "saveRequestAndResponseBodies" on pref change when we instanciate this NetworkMonitor instance in the child process.
See comment 0 for more info about this patch. Feel free to redirect the review to whoever would be best looking at that.
Attachment #8709956 - Flags: review?(vporof)
Comment on attachment 8709956 [details] [diff] [review] patch v1 Review of attachment 8709956 [details] [diff] [review]: ----------------------------------------------------------------- Do we want to temporarily just omit these requests or have them displayed in the netmonitor at some point?
Attachment #8709956 - Flags: review?(vporof) → review+
These requests (Cache/ServiceWorker/Fetch) are already displayed, but with stuff being incorrect or broken (transfered size empty, and empty response content panel).
https://hg.mozilla.org/integration/fx-team/rev/afb7e27d06f569b5dbc6d477ce09135101fd5097 Bug 1240762 - Fix ServiceWorker request coming from Cache/Fetch. r=vporof
You need to log in before you can comment on or make changes to this bug.