1240766 - crash in mozilla::dom::Geolocation::Init

Status: RESOLVED FIXED

(Core :: DOM: Geolocation, defect)

Description

[Tracy Walker [:tracy]]

This bug was filed from the Socorro interface and is 
report bp-7b5f85a9-97c6-4629-b104-5c9fb2160118.
=============================================================

This is a startup crash that jumped to #1 in volume on Nightly since it first appeared on in 20160115055328 builds.  There is notable volume on Windows and Mac 10.11.

Comment 1

[Josh Matthews [:jdm]]

Null URI retrieved from the principal for the purposes of gathering telemetry. Curious.

Comment 2

[Josh Matthews [:jdm]]

Could be the system principal? Geolocation being used from extensions, perhaps?

Comment 3

[Tim Taubert [:ttaubert] (inactive)]

Interesting, I assumed that we wouldn't get there when used by chrome/c++ due to the comment at the bottom of the Init() function:

> // If no aContentDom was passed into us, we are being used
> // by chrome/c++ and have no mOwner, no mPrincipal, and no need
> // to prompt.

So is the right way to fix this simply to check if (uri) { ... } ?

Comment 4

[Josh Matthews [:jdm]]

Seems reasonable to me.

Comment 5

[Tim Taubert [:ttaubert] (inactive)]

Attachment: 0001-Bug-1240766-Fix-startup-crash-in-Geolocation-Init-wh.patch

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/56c7becfd682

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/56c7becfd682