124080 - need secure LDAP server icon for addressbook dir pane

Status: VERIFIED FIXED

(SeaMonkey :: MailNews: Address Book & Contacts, defect)

Description

[(not reading, please use [e-mail] instead)]

need secure LDAP server icon for addressbook dir pane

right now, secure (and non-secure) LDAP servers will use the same icon:  the 
remote addressbook icon.

Comment 1

[jglick]

Assigning to Marlon so the nec icon(s) are created. Marlon, assign back to 
Srilatha when you are ready.

Comment 2

[jglick]

Attachment: Example

Example of potential Secure LDAP dir icon. Similar to secure news servers. Need
and open and closed version.

Comment 3

[marlon bishop]

accepting

Comment 4

[(not reading, please use [e-mail] instead)]

I'm not sure if there were classic 4.x icons for this, but we can check.

if there weren't, should we add them?

Comment 5

[jglick]

If we are still supporting the Classic theme, yup, need classic versions as 
well. Toy Factory too.

Comment 6

[marlon bishop]

Attachment: secure ldap directory icons

Comment 7

[marlon bishop]

here are the modern icons.  gail you want this bug reassigned to you for 
the toyfactory or classic ones?  i could do those too, but i might not be 
able to get to them for a while.

Comment 8

[marlon bishop]

assigning to gail

Comment 9

[(not reading, please use [e-mail] instead)]

after #107411 is finished, we can add this UI polish.

Comment 10

[jglick]

Bug 107411 is fixed (4/02). Once icons are available, we can finish this bug up.

Comment 11

[Lori Kaplan]

approving for Buffy. Gail, please finish these icons asap. 

Comment 12

[gail]

Attachment: Secure LDAP for classic skin

Comment 13

[gail]

Attachment: Secure LDAP icon for Toy Factory skin

Comment 14

[jglick]

Back over to Seth for implementation. Thanks Gail and Marlon.

Comment 15

[(not reading, please use [e-mail] instead)]

Attachment: patch

there are some spin off issues:

1) transparency of modern icon is wrong
2) icon doesn't change when you toggle the state (requires close / open, or
restart)
3) show secure icon in other UI places (including compose window?)

Comment 16

[(not reading, please use [e-mail] instead)]

hoping for final.

before I check in, I'll fix the pref usage too, since that pref usage is
obsolete (I copied and pasted)

Comment 17

[(not reading, please use [e-mail] instead)]

Attachment: patch

Comment 18

[(not reading, please use [e-mail] instead)]

Comment on attachment 113028 [details] [diff] [review]
patch

this has sr=bienvenu over aim.

Comment 19

[Asa Dotzler [:asa]]

Comment on attachment 113028 [details] [diff] [review]
patch

a=asa (on behalf of drivers) for checkin to 1.3beta.

Comment 20

[(not reading, please use [e-mail] instead)]

fixed, but I know of at least three spin off bugs:

1) transparency of modern icon is wrong
2) icon doesn't change when you toggle the secure state (requires addressbook
window, close / open, or application restart)
3) show secure ldap icon in other UI places (including compose window, for
autocomplete?)

Comment 21

[jglick]

>1) transparency of modern icon is wrong

Visual issue. Gail is going to fix. :-)

>2) icon doesn't change when you toggle the secure state (requires addressbook
>window, close / open, or application restart)

Code issue, right (you have the needed icons)?

>3) show secure ldap icon in other UI places (including compose window, for
>autocomplete?)

Code issue, right?

Comment 22

[gail]

>>1) transparency of modern icon is wrong

>Visual issue. Gail is going to fix. :-)

Gail fixed. Sent to Seth.

Comment 23

[(not reading, please use [e-mail] instead)]

>>1) transparency of modern icon is wrong
>Visual issue. Gail is going to fix. :-)

I got the updated icon and checked it in, thanks gail.

>>2) icon doesn't change when you toggle the secure state (requires addressbook
>>window, close / open, or application restart)
>Code issue, right (you have the needed icons)?

yes, code issue.  logged as bug #191354

>>3) show secure ldap icon in other UI places (including compose window, for
>>autocomplete?)
>Code issue, right?

yes, code issue.  logged as see bug #191355

I was just being lazy last night.  (could have spun them off then, instead of
just listing them)

Comment 24

[Cavin Song]

Comment on attachment 113028 [details] [diff] [review]
patch

r=cavin. minor indent issue in createDirectoryIsSecureNode().

Comment 25

[(not reading, please use [e-mail] instead)]

I've fixed the whitespace issue in my local tree, and will land it the next time
the tree is open for non-approved checkins.

Comment 26

[(not reading, please use [e-mail] instead)]

I've checked in the whitespace cleanup, thanks for catching it, cavin.

Comment 27

[Ninoschka Baca]

Trunk build 2003-03-03: WinXP, Linux RH 8
Trunk build 2003-02-25: Mac 10.1.5
Verified Fixed. Checked Classic and Modern themes. The secure icon appears for
LDAP directories in the left pane of the address book window.