1240896 - Switch to iframe mozbrowser

Status: RESOLVED FIXED

(DevTools :: Responsive Design Mode, defect, P1)

Description

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

The initial shell in bug 1239437 uses a regular <iframe> to display the web content.  This is not what we want to actually ship.

Instead, we need to change to <iframe mozbrowser>, which gives a truly separate browser runtime (similar to <xul:browser>), allows running in a child process, etc.

Bug 1238160 tracks enabling this feature on desktop.  Once it is, we can enable it in RDM here.

Comment 1

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

I'm removing swapFrameLoaders (bug 1242644) from the scope of this bug, as it's making things too complex to switch to mozbrowser *and* use swapFrameLoaders in the same task.

Bug 1240913 is likely where we'll make use of swapFrameLoaders.

Comment 2

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Attachment: MozReview Request: Bug 1240896 - Use iframe mozbrowser in RDM. r=gl

Review commit: https://reviewboard.mozilla.org/r/43973/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/43973/

Comment 3

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Attachment: MozReview Request: Bug 1240896 - Uplift dimensions to avoid recreating iframe. r=gl

Review commit: https://reviewboard.mozilla.org/r/43975/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/43975/

Comment 4

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Attachment: MozReview Request: Bug 1240896 - Reorder imports to match style. r=gl

Review commit: https://reviewboard.mozilla.org/r/43977/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/43977/

Comment 5

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Attachment: MozReview Request: Bug 1240896 - Port browser_resize_cmd.js, add resize to support. r=gl

Review commit: https://reviewboard.mozilla.org/r/43979/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/43979/

Comment 6

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Attachment: MozReview Request: Bug 1240896 - Load frame script into RDM browser. r=gl

Review commit: https://reviewboard.mozilla.org/r/43981/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/43981/

Comment 7

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Attachment: MozReview Request: Bug 1240896 - Port browser_device_width.js to new RDM. r=gl

This also adds the test infrastructure for detecting content resizing.

Review commit: https://reviewboard.mozilla.org/r/43983/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/43983/

Comment 8

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=74b606fc8fcb

Comment 9

[Gabriel Luong [:gl] (ΦωΦ)]

Comment on attachment 8737437 [details]
MozReview Request: Bug 1240896 - Use iframe mozbrowser in RDM. r=gl

https://reviewboard.mozilla.org/r/43973/#review40693

Comment 10

[Gabriel Luong [:gl] (ΦωΦ)]

Comment on attachment 8737438 [details]
MozReview Request: Bug 1240896 - Uplift dimensions to avoid recreating iframe. r=gl

https://reviewboard.mozilla.org/r/43975/#review40711

Comment 11

[Gabriel Luong [:gl] (ΦωΦ)]

Comment on attachment 8737439 [details]
MozReview Request: Bug 1240896 - Reorder imports to match style. r=gl

https://reviewboard.mozilla.org/r/43977/#review40713

Comment 12

[Gabriel Luong [:gl] (ΦωΦ)]

Comment on attachment 8737440 [details]
MozReview Request: Bug 1240896 - Port browser_resize_cmd.js, add resize to support. r=gl

https://reviewboard.mozilla.org/r/43979/#review40729

I think the commit msg should be: Port browser_responsive_cmd.js, add gcli resize support

Comment 13

[Gabriel Luong [:gl] (ΦωΦ)]

Comment on attachment 8737441 [details]
MozReview Request: Bug 1240896 - Load frame script into RDM browser. r=gl

https://reviewboard.mozilla.org/r/43981/#review40757

Comment 14

[Gabriel Luong [:gl] (ΦωΦ)]

Comment on attachment 8737442 [details]
MozReview Request: Bug 1240896 - Port browser_device_width.js to new RDM. r=gl

https://reviewboard.mozilla.org/r/43983/#review40803

Comment 15

[Gabriel Luong [:gl] (ΦωΦ)]

I noticed that we will get an error for google.com with these patches applied.

STR: 
1. Navigate to http://google.com/
2. Open RDM
3. Observe console error
DOMException [SyntaxError: "An invalid or illegal string was specified"
code: 12
nsresult: 0x8053000c
index.js:125:5

Comment 16

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

(In reply to Gabriel Luong [:gl] (ΦωΦ) from comment #12)
> Comment on attachment 8737440 [details]
> MozReview Request: Bug 1240896 - Port browser_resize_cmd.js, add resize to
> support. r=gl
> 
> https://reviewboard.mozilla.org/r/43979/#review40729
> 
> I think the commit msg should be: Port browser_responsive_cmd.js, add gcli
> resize support

Okay, renamed.

Comment 17

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

(In reply to Gabriel Luong [:gl] (ΦωΦ) from comment #15)
> I noticed that we will get an error for google.com with these patches
> applied.
> 
> STR: 
> 1. Navigate to http://google.com/
> 2. Open RDM
> 3. Observe console error
> DOMException [SyntaxError: "An invalid or illegal string was specified"
> code: 12
> nsresult: 0x8053000c
> index.js:125:5

Ah, good catch, I needed to escape any instances of & in the URL.

Comment 18

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/0070ee7b52a3
https://hg.mozilla.org/integration/fx-team/rev/d9b17ba5ebc2
https://hg.mozilla.org/integration/fx-team/rev/a6c421e444d0
https://hg.mozilla.org/integration/fx-team/rev/311e7a5e811b
https://hg.mozilla.org/integration/fx-team/rev/9bf82cf8e9a2
https://hg.mozilla.org/integration/fx-team/rev/6d6b9a38bc48
https://hg.mozilla.org/integration/fx-team/rev/01267cc7cc8f
https://hg.mozilla.org/integration/fx-team/rev/c725fad03087
https://hg.mozilla.org/integration/fx-team/rev/8fc46323cee6

Comment 19

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/0070ee7b52a3
https://hg.mozilla.org/mozilla-central/rev/d9b17ba5ebc2
https://hg.mozilla.org/mozilla-central/rev/a6c421e444d0
https://hg.mozilla.org/mozilla-central/rev/311e7a5e811b
https://hg.mozilla.org/mozilla-central/rev/9bf82cf8e9a2
https://hg.mozilla.org/mozilla-central/rev/6d6b9a38bc48
https://hg.mozilla.org/mozilla-central/rev/01267cc7cc8f
https://hg.mozilla.org/mozilla-central/rev/c725fad03087
https://hg.mozilla.org/mozilla-central/rev/8fc46323cee6