1240905 - marionettejs http.Server should be close()-ed, not kill()-ed.

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Shared, defect)

Description

[Sam Foster [:sfoster] (he/him)]

There's a couple instances where we call .kill() on a http.Server instance. There is no kill method; we should call .close()

Comment 1

[GitHub Autolander Bot]

Attachment: [gaia] sfoster:close-server-bug-1240905 > mozilla-b2g:master

Comment 2

[Sam Foster [:sfoster] (he/him)]

Comment on attachment 8709636 [details] [review]
[gaia] sfoster:close-server-bug-1240905 > mozilla-b2g:master

I just found these 2 instances of this problem. This is code in /shared/ but I'm not sure its the correct component? Either way you seemed like an appropriate reviewer, but please forward it along if not.

Comment 3

[Aus Lacroix [:aus]]

Comment on attachment 8709636 [details] [review]
[gaia] sfoster:close-server-bug-1240905 > mozilla-b2g:master

Looks good! I also checked and even in node 0.10 and 0.12, kill was removed. We must've been using a wrapper for a while and then replaced it with the straight up HTTP Server class from nodejs but failed to remove the use of 'kill' and instead use 'close'. I'm really surprised it didn't break things sooner! Sorry you had to step on that landmine but SUPER happy it's fixed!

Comment 4

[Sam Foster [:sfoster] (he/him)]

There's a lot of blue in the test run here. I'm not clear if this is normal - is this good to land? 

https://treeherder.mozilla.org/#/jobs?repo=gaia&revision=7a25267bc249c852cfc7d3552f28327d5c41b2e7

Comment 5

[Michael Henretty [:mikehenrty][:mhenretty]]

Yup, those blues are pretty normal these days:
https://treeherder.mozilla.org/#/jobs?repo=gaia-master

Comment 6

[Sam Foster [:sfoster] (he/him)]

Merged to master: https://github.com/mozilla-b2g/gaia/commit/b7d18e723aba7c60fd15c9d0828f3e190853b752