1240906 - Shut down nsGeolocationService at xpcom-shutdown, not quit-application

Status: RESOLVED FIXED

(Core :: DOM: Device Interfaces, defect)

Description

[Andrew McCreight (out of office until 8/21) [:mccr8]]

It is more standard to shut things down at xpcom-shutdown. I looked at the landing of this patch and it didn't seem like there was any particular reason to use quit-application instead.

Comment 1

[Andrew McCreight (out of office until 8/21) [:mccr8]]

Attachment: Shut down geolocation service at xpcom-shutdown instead of quit-application.

Also, remove trailing spaces from network_geolocation.sjs.

try run: https://treeherder.mozilla.org/#/jobs?repo=try&revision=ede1cf265db5

Comment 2

[Doug Turner (:dougt)]

what about all of the other places where we call quit-application?

Comment 3

[Andrew McCreight (out of office until 8/21) [:mccr8]]

(In reply to Doug Turner (:dougt) from comment #2)
> what about all of the other places where we call quit-application?

Yeah, I'm not really sure. I think it is just a good idea to shut down anything that uses CC in xpcom-shutdown, so we can sure it will get cleaned up. I'm not sure when quit-application actually happens.

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/853a4f26a3f5

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/853a4f26a3f5