Closed Bug 1240906 Opened 5 years ago Closed 5 years ago

Shut down nsGeolocationService at xpcom-shutdown, not quit-application

Categories

(Core :: DOM: Device Interfaces, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla47
Tracking Status
firefox46 --- affected
firefox47 --- fixed

People

(Reporter: mccr8, Assigned: mccr8)

Details

Attachments

(1 file)

It is more standard to shut things down at xpcom-shutdown. I looked at the landing of this patch and it didn't seem like there was any particular reason to use quit-application instead.
what about all of the other places where we call quit-application?
(In reply to Doug Turner (:dougt) from comment #2)
> what about all of the other places where we call quit-application?

Yeah, I'm not really sure. I think it is just a good idea to shut down anything that uses CC in xpcom-shutdown, so we can sure it will get cleaned up. I'm not sure when quit-application actually happens.
Attachment #8709642 - Flags: review?(dougt) → review+
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/853a4f26a3f5
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla47
You need to log in before you can comment on or make changes to this bug.