Closed
Bug 1240919
Opened 9 years ago
Closed 9 years ago
Remove old FxAccountClient10 code from Fennec
Categories
(Firefox for Android Graveyard :: Android Sync, defect)
Firefox for Android Graveyard
Android Sync
Tracking
(firefox46 fixed)
RESOLVED
FIXED
Firefox 46
Tracking | Status | |
---|---|---|
firefox46 | --- | fixed |
People
(Reporter: nalexander, Assigned: nalexander)
References
Details
Attachments
(6 files)
58 bytes,
text/x-review-board-request
|
rnewman
:
review+
|
Details |
58 bytes,
text/x-review-board-request
|
rnewman
:
review+
|
Details |
58 bytes,
text/x-review-board-request
|
rnewman
:
review+
|
Details |
58 bytes,
text/x-review-board-request
|
rnewman
:
review+
|
Details |
58 bytes,
text/x-review-board-request
|
rnewman
:
review+
|
Details |
58 bytes,
text/x-review-board-request
|
rnewman
:
review+
|
Details |
We have a bunch of old Firefox Accounts code in Fennec that uses SRP to negotiate tokens from the fxa-auth-server. This approach has never been used in production; let's purge it.
Assignee | ||
Comment 1•9 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/31507/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/31507/
Attachment #8709670 -
Flags: review?(rnewman)
Assignee | ||
Comment 2•9 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/31509/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/31509/
Attachment #8709671 -
Flags: review?(rnewman)
Assignee | ||
Comment 3•9 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/31511/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/31511/
Attachment #8709672 -
Flags: review?(rnewman)
Assignee | ||
Comment 4•9 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/31513/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/31513/
Attachment #8709673 -
Flags: review?(rnewman)
Assignee | ||
Comment 5•9 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/31515/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/31515/
Attachment #8709674 -
Flags: review?(rnewman)
Assignee | ||
Comment 6•9 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/31517/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/31517/
Attachment #8709675 -
Flags: review?(rnewman)
Assignee | ||
Comment 7•9 years ago
|
||
Comment on attachment 8709671 [details]
MozReview Request: Bug 1240919 - Part 2: Cull more client v1 code. r?rnewman
Review request updated; see interdiff: https://reviewboard.mozilla.org/r/31509/diff/1-2/
Assignee | ||
Comment 8•9 years ago
|
||
Comment on attachment 8709672 [details]
MozReview Request: Bug 1240919 - Part 3: Cull unused methods. r?rnewman
Review request updated; see interdiff: https://reviewboard.mozilla.org/r/31511/diff/1-2/
Assignee | ||
Comment 9•9 years ago
|
||
Comment on attachment 8709673 [details]
MozReview Request: Bug 1240919 - Part 4a: Merge FxAccountClient20 into Client10, in preparation for swap. r?rnewman
Review request updated; see interdiff: https://reviewboard.mozilla.org/r/31513/diff/1-2/
Assignee | ||
Comment 10•9 years ago
|
||
Comment on attachment 8709674 [details]
MozReview Request: Bug 1240919 - Part 4b: Make FxAccountClient10 be Client20, completing swap. r?rnewman
Review request updated; see interdiff: https://reviewboard.mozilla.org/r/31515/diff/1-2/
Assignee | ||
Comment 11•9 years ago
|
||
Comment on attachment 8709675 [details]
MozReview Request: Bug 1240919 - Part 5: Remove references to org.json.simple in org.mozilla.gecko.background.fxa. r?rnewman
Review request updated; see interdiff: https://reviewboard.mozilla.org/r/31517/diff/1-2/
Assignee | ||
Comment 12•9 years ago
|
||
Updated•9 years ago
|
Attachment #8709670 -
Flags: review?(rnewman) → review+
Comment 13•9 years ago
|
||
Comment on attachment 8709670 [details]
MozReview Request: Bug 1240919 - Part 1: Start culling old Firefox Accounts code. r?rnewman
https://reviewboard.mozilla.org/r/31507/#review28227
Comment 14•9 years ago
|
||
Comment on attachment 8709671 [details]
MozReview Request: Bug 1240919 - Part 2: Cull more client v1 code. r?rnewman
https://reviewboard.mozilla.org/r/31509/#review28229
Attachment #8709671 -
Flags: review?(rnewman) → review+
Comment 15•9 years ago
|
||
Comment on attachment 8709672 [details]
MozReview Request: Bug 1240919 - Part 3: Cull unused methods. r?rnewman
https://reviewboard.mozilla.org/r/31511/#review28231
Attachment #8709672 -
Flags: review?(rnewman) → review+
Updated•9 years ago
|
Attachment #8709673 -
Flags: review?(rnewman) → review+
Comment 16•9 years ago
|
||
Comment on attachment 8709673 [details]
MozReview Request: Bug 1240919 - Part 4a: Merge FxAccountClient20 into Client10, in preparation for swap. r?rnewman
https://reviewboard.mozilla.org/r/31513/#review28233
Comment 17•9 years ago
|
||
Comment on attachment 8709674 [details]
MozReview Request: Bug 1240919 - Part 4b: Make FxAccountClient10 be Client20, completing swap. r?rnewman
https://reviewboard.mozilla.org/r/31515/#review28235
Attachment #8709674 -
Flags: review?(rnewman) → review+
Comment 18•9 years ago
|
||
Comment on attachment 8709675 [details]
MozReview Request: Bug 1240919 - Part 5: Remove references to org.json.simple in org.mozilla.gecko.background.fxa. r?rnewman
https://reviewboard.mozilla.org/r/31517/#review28237
Attachment #8709675 -
Flags: review?(rnewman) → review+
Assignee | ||
Comment 19•9 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/2cffe56c205e33399c7485b3660476ab4272c0dd
Bug 1240919 - Part 1: Start culling old Firefox Accounts code. r=rnewman
https://hg.mozilla.org/integration/fx-team/rev/d09ba092a9d28305247f9bdab4513602fab1785e
Bug 1240919 - Part 2: Cull more client v1 code. r=rnewman
https://hg.mozilla.org/integration/fx-team/rev/902120f314e9bd79dd1fa447688b8ea8adab9f6c
Bug 1240919 - Part 3: Cull unused methods. r=rnewman
https://hg.mozilla.org/integration/fx-team/rev/f6d45cf07a4a65e129c10eaeadf1867d026fc045
Bug 1240919 - Part 4a: Merge FxAccountClient20 into Client10, in preparation for swap. r=rnewman
https://hg.mozilla.org/integration/fx-team/rev/a4056a35eaa108d44ab669cae0ce9e871c555fc3
Bug 1240919 - Part 4b: Make FxAccountClient10 be Client20, completing swap. r=rnewman
https://hg.mozilla.org/integration/fx-team/rev/ed222e27eb642c27d4d24dd437121f1047c97744
Bug 1240919 - Part 5: Remove references to org.json.simple in org.mozilla.gecko.background.fxa. r=rnewman
Comment 20•9 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/2cffe56c205e
https://hg.mozilla.org/mozilla-central/rev/d09ba092a9d2
https://hg.mozilla.org/mozilla-central/rev/902120f314e9
https://hg.mozilla.org/mozilla-central/rev/f6d45cf07a4a
https://hg.mozilla.org/mozilla-central/rev/a4056a35eaa1
https://hg.mozilla.org/mozilla-central/rev/ed222e27eb64
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox46:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 46
Updated•7 years ago
|
Product: Android Background Services → Firefox for Android
Updated•4 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•