Closed
Bug 1240977
Opened 10 years ago
Closed 9 years ago
TestDllInterceptor fails on Windows 10 x64 with ntdll functions
Categories
(Core :: General, defect)
Tracking
()
RESOLVED
FIXED
mozilla52
Tracking | Status | |
---|---|---|
firefox52 | --- | fixed |
People
(Reporter: bugzilla, Assigned: bugzilla)
References
Details
Attachments
(1 file, 3 obsolete files)
5.98 KB,
patch
|
bugzilla
:
review+
|
Details | Diff | Splinter Review |
Looks like there are TEST instructions in there that our code does not understand.
Assignee | ||
Updated•10 years ago
|
OS: Windows → Windows 10
Hardware: Unspecified → x86_64
Assignee | ||
Comment 1•10 years ago
|
||
The DLL interceptor tests fail on Windows 10 without this patch. With this patch, they succeed.
I took the opportunity to add some smarts about modr/m and SIB bytes. Hopefully this will permit us to start taking more advantage of structure in the instruction set in the future.
Comment 2•10 years ago
|
||
Comment on attachment 8710030 [details] [diff] [review]
Patch
Review of attachment 8710030 [details] [diff] [review]:
-----------------------------------------------------------------
::: xpcom/build/nsWindowsDllInterceptor.h
@@ +516,5 @@
> + numBytes += 4;
> + }
> + break;
> + default:
> + // This should not be reachable
MOZ_ASSERT_UNREACHABLE please.
Attachment #8710030 -
Flags: review?(ehsan) → review+
Assignee | ||
Comment 3•10 years ago
|
||
Updated as requested. Carrying forward r+.
Attachment #8710030 -
Attachment is obsolete: true
Attachment #8710175 -
Flags: review+
Assignee | ||
Comment 4•10 years ago
|
||
For real
Attachment #8710175 -
Attachment is obsolete: true
Attachment #8710177 -
Flags: review+
Assignee | ||
Updated•10 years ago
|
Keywords: checkin-needed
Keywords: checkin-needed
Comment 6•10 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla46
Comment 7•10 years ago
|
||
Backed out along with bug 1240848 under the suspicion that bug 1240848 was the cause of bug 1241921.
https://hg.mozilla.org/mozilla-central/rev/5f7c184ccd80
Status: RESOLVED → REOPENED
status-firefox46:
fixed → ---
Resolution: FIXED → ---
Target Milestone: mozilla46 → ---
Comment 8•9 years ago
|
||
Aaron recommends that this bug block the 64-bit Firefox roll-out.
Blocks: support-win64
Assignee | ||
Comment 9•9 years ago
|
||
Newly rebased. Carrying forward r+.
Attachment #8710177 -
Attachment is obsolete: true
Attachment #8800894 -
Flags: review+
Assignee | ||
Comment 10•9 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/78344bbde6134a8be1c22d159730189c876205af
Bug 1240977: DLL interceptor improvements for Windows 10 x64 ntdll APIs; r=ehsan
Comment 11•9 years ago
|
||
bugherder |
Status: REOPENED → RESOLVED
Closed: 10 years ago → 9 years ago
status-firefox52:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
You need to log in
before you can comment on or make changes to this bug.
Description
•