1240977 - TestDllInterceptor fails on Windows 10 x64 with ntdll functions

Status: RESOLVED FIXED

Description

[Aaron Klotz [:aklotz] (a11y work receiving priority right now, please send interceptor reviews to dmajor or handyman)]

Looks like there are TEST instructions in there that our code does not understand.

Comment 1

[Aaron Klotz [:aklotz] (a11y work receiving priority right now, please send interceptor reviews to dmajor or handyman)]

Created attachment 8710030 [details] [diff] [review]
Patch

The DLL interceptor tests fail on Windows 10 without this patch. With this patch, they succeed.

I took the opportunity to add some smarts about modr/m and SIB bytes. Hopefully this will permit us to start taking more advantage of structure in the instruction set in the future.

Comment 2

[:Ehsan Akhgari (needinfo please, extremely long backlog)]

Comment on attachment 8710030 [details] [diff] [review]
Patch

Review of attachment 8710030 [details] [diff] [review]:
-----------------------------------------------------------------

::: xpcom/build/nsWindowsDllInterceptor.h
@@ +516,5 @@
> +          numBytes += 4;
> +        }
> +        break;
> +      default:
> +        // This should not be reachable

MOZ_ASSERT_UNREACHABLE please.

Comment 3

[Aaron Klotz [:aklotz] (a11y work receiving priority right now, please send interceptor reviews to dmajor or handyman)]

Created attachment 8710175 [details] [diff] [review]
Patch (r2)

Updated as requested. Carrying forward r+.

Comment 4

[Aaron Klotz [:aklotz] (a11y work receiving priority right now, please send interceptor reviews to dmajor or handyman)]

Created attachment 8710177 [details] [diff] [review]
Patch (r3)

For real

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/9f34b95fa1d0

Comment 6

[Wes Kocher (:KWierso)]

https://hg.mozilla.org/mozilla-central/rev/9f34b95fa1d0

Comment 7

[Ryan VanderMeulen [:RyanVM]]

Backed out along with bug 1240848 under the suspicion that bug 1240848 was the cause of bug 1241921.
https://hg.mozilla.org/mozilla-central/rev/5f7c184ccd80

Comment 8

[Chris Peterson [:cpeterson]]

Aaron recommends that this bug block the 64-bit Firefox roll-out.

Comment 9

[Aaron Klotz [:aklotz] (a11y work receiving priority right now, please send interceptor reviews to dmajor or handyman)]

Created attachment 8800894 [details] [diff] [review]
Patch (r4)

Newly rebased. Carrying forward r+.

Comment 10

[Aaron Klotz [:aklotz] (a11y work receiving priority right now, please send interceptor reviews to dmajor or handyman)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/78344bbde6134a8be1c22d159730189c876205af
Bug 1240977: DLL interceptor improvements for Windows 10 x64 ntdll APIs; r=ehsan

Comment 11

[Carsten Book [:Tomcat] - PTO - back July 23rd]

https://hg.mozilla.org/mozilla-central/rev/78344bbde613