Closed Bug 1240977 Opened 4 years ago Closed 4 years ago

TestDllInterceptor fails on Windows 10 x64 with ntdll functions

Categories

(Core :: General, defect)

Product:
Core
Component:
General
Platform:
x86_64
Windows 10
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla52
Tracking Flags:
Tracking Status
firefox52 --- fixed

People

(Reporter: aklotz, Assigned: aklotz)

References

Details

Attachments

(1 file, 3 obsolete files)

Patch (r4)
5.98 KB, patch
aklotz
: review+
Details | Diff | Splinter Review 
Looks like there are TEST instructions in there that our code does not understand.
OS: Windows → Windows 10
Hardware: Unspecified → x86_64
Attached patch Patch (obsolete) — — Splinter Review 
The DLL interceptor tests fail on Windows 10 without this patch. With this patch, they succeed.

I took the opportunity to add some smarts about modr/m and SIB bytes. Hopefully this will permit us to start taking more advantage of structure in the instruction set in the future.
Assignee: nobody → aklotz
Status: NEW → ASSIGNED
Attachment #8710030 - Flags: review?(ehsan)
Comment on attachment 8710030 [details] [diff] [review]
Patch

Review of attachment 8710030 [details] [diff] [review]:
-----------------------------------------------------------------

::: xpcom/build/nsWindowsDllInterceptor.h
@@ +516,5 @@
> +          numBytes += 4;
> +        }
> +        break;
> +      default:
> +        // This should not be reachable

MOZ_ASSERT_UNREACHABLE please.
Attachment #8710030 - Flags: review?(ehsan) → review+
Attached patch Patch (r2) (obsolete) — — Splinter Review 
Updated as requested. Carrying forward r+.
Attachment #8710030 - Attachment is obsolete: true
Attachment #8710175 - Flags: review+
Attached patch Patch (r3) (obsolete) — — Splinter Review 
For real
Attachment #8710175 - Attachment is obsolete: true
Attachment #8710177 - Flags: review+
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/9f34b95fa1d0
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox46: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla46
Backed out along with bug 1240848 under the suspicion that bug 1240848 was the cause of bug 1241921.
https://hg.mozilla.org/mozilla-central/rev/5f7c184ccd80
Status: RESOLVED → REOPENED
status-firefox46: fixed → ---
Resolution: FIXED → ---
Target Milestone: mozilla46 → ---
Aaron recommends that this bug block the 64-bit Firefox roll-out.
Blocks: support-win64
Attached patch Patch (r4) — — Splinter Review 
Newly rebased. Carrying forward r+.
Attachment #8710177 - Attachment is obsolete: true
Attachment #8800894 - Flags: review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/78344bbde6134a8be1c22d159730189c876205af
Bug 1240977: DLL interceptor improvements for Windows 10 x64 ntdll APIs; r=ehsan
https://hg.mozilla.org/mozilla-central/rev/78344bbde613
Status: REOPENED → RESOLVED
Closed: 4 years ago → 4 years ago
status-firefox52: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
Depends on: 1314183
You need to log in before you can comment on or make changes to this bug.