1240978 - Shorten the max timeout of black screen in fullscreen transition

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Xidorn Quan [:xidorn] UTC+10]

In the initial implementation, I set a one second timeout for fullscreen transition's staying in black, so that in case that something unexpected happens, we wouldn't get stuck in the black screen.

It seems in some machines, doing the fullscreen reflow on Youtube could even take longer than one second. Staying in black screen for a long time could be a even poorer experience than exposing an intermediate state. Thus we may want to shorten the timeout to something like 300ms.

Hopefully this would help mitigating bug 1187769.

Comment 1

[Xidorn Quan [:xidorn] UTC+10]

Attachment: MozReview Request: Bug 1240978 - Shorten timeout for black screen in fullscreen transition.

Review commit: https://reviewboard.mozilla.org/r/31579/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/31579/

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8709836 [details]
MozReview Request: Bug 1240978 - Shorten timeout for black screen in fullscreen transition.

https://reviewboard.mozilla.org/r/31579/#review28313

But either way, up to you to decrease the default or use some pref.

::: dom/base/nsGlobalWindow.cpp:5886
(Diff revision 1)
> -  static const uint32_t kNextPaintTimeout = 1000; // ms
> +  static const uint32_t kNextPaintTimeout = 500; // ms

I wonder if this should be controlled by some pref so that people on different machines could try out which works best and then we could select some good default.

Comment 3

[Xidorn Quan [:xidorn] UTC+10]

Comment on attachment 8709836 [details]
MozReview Request: Bug 1240978 - Shorten timeout for black screen in fullscreen transition.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/31579/diff/1-2/

Comment 4

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8709836 [details]
MozReview Request: Bug 1240978 - Shorten timeout for black screen in fullscreen transition.

https://reviewboard.mozilla.org/r/31579/#review28815

Comment 5

[Xidorn Quan [:xidorn] UTC+10]

https://hg.mozilla.org/integration/mozilla-inbound/rev/62b5f4684fa94c890beae19ef7e47fa9159ff151
Bug 1240978 - Shorten timeout for black screen in fullscreen transition. r=smaug

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/62b5f4684fa9