Closed Bug 1240991 Opened 4 years ago Closed 4 years ago
__ from Firefox Media Harness and update requirements
53 bytes, text/x-github-pull-request
|Details | Review|
MozReview Request: Bug 1240991 - Remove __init__ from FirefoxMediaHarness and update requirements. r?maja_zf
58 bytes, text/x-review-board-request
FirefoxMediaHarness.__init__ implements a workaround for Bug 1227918. Let's remove it! It also breaks as a result of adding the 'args' keyword argument to the call to `harness_class` in runtests:cli [1,2], so let's remove it quickly!  https://dxr.mozilla.org/mozilla-central/source/testing/marionette/client/marionette/runtests.py#91  https://hg.mozilla.org/mozilla-central/rev/853bcd30706a
4 years ago
Summary: Remove __init__ from FirefoxMediaHarness → Remove __init__ from FirefoxMediaHarness and update requirements
I need to fix both the github repo and m-c, because the github repo is still referenced by buildbot jobs on all m-c branches. I will fix m-c after bug 1240120 lands. (The code in m-c isn't being used anywhere for now, so I'd rather wait for Syd to finalize his restructuring.) I tested my change on a few pf-jenkins branches and everything seems to work fine: http://pf-jenkins.qa.mtv2.mozilla.com:8080/view/temp/job/temp_test-mn-mse-youtube-basic-y-nightly-mac/73/console http://pf-jenkins.qa.mtv2.mozilla.com:8080/view/temp/job/temp_mn-mse-bw-limits-youtube-default-nightly-mac/3/consoleFull
Comment on attachment 8710493 [details] [review] Link to Github pull-request: https://github.com/mjzffr/firefox-media-tests/pull/37 This cannot be closed until the mozilla-central version is in tree, but the github version is good to go.
Attachment #8710493 - Flags: review?(spolk) → review+
> This cannot be closed until the mozilla-central version is in tree Agreed. As discussed, I have the m-c patch ready but I will hold off until bug 1240120 lands.
Merged and rebased onto pf-jenkins branch https://github.com/mjzffr/firefox-media-tests/commit/20c19d094e67cef81f9b33e2f7e5d00a3d9c23ec This means that media jobs running in pf-jenkins are using the latest marionette-* releases (i.e. bug 1238996)
Review commit: https://reviewboard.mozilla.org/r/31977/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/31977/
Attachment #8711103 - Flags: review?(mjzffr)
Comment on attachment 8711103 [details] MozReview Request: Bug 1240991 - Remove __init__ from FirefoxMediaHarness and update requirements. r?maja_zf https://reviewboard.mozilla.org/r/31977/#review28713
Attachment #8711103 - Flags: review?(mjzffr) → review+
Comment on attachment 8711103 [details] MozReview Request: Bug 1240991 - Remove __init__ from FirefoxMediaHarness and update requirements. r?maja_zf https://reviewboard.mozilla.org/r/31977/#review28715
Attachment #8711103 - Flags: review+
You need to log in before you can comment on or make changes to this bug.