Remove __init__ from FirefoxMediaHarness and update requirements

RESOLVED FIXED in mozilla46

Status

Testing Graveyard
external-media-tests
P1
normal
RESOLVED FIXED
2 years ago
5 months ago

People

(Reporter: maja_zf, Assigned: maja_zf)

Tracking

unspecified
mozilla46
Dependency tree / graph

Details

MozReview Requests

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(2 attachments)

FirefoxMediaHarness.__init__ implements a workaround for Bug 1227918. Let's remove it! 

It also breaks as a result of adding the 'args' keyword argument to the call to `harness_class` in runtests:cli [1,2], so let's remove it quickly!

[1] https://dxr.mozilla.org/mozilla-central/source/testing/marionette/client/marionette/runtests.py#91
[2] https://hg.mozilla.org/mozilla-central/rev/853bcd30706a
(Assignee)

Updated

2 years ago
Summary: Remove __init__ from FirefoxMediaHarness → Remove __init__ from FirefoxMediaHarness and update requirements
(Assignee)

Comment 1

2 years ago
I need to fix both the github repo and m-c, because the github repo is still referenced by buildbot jobs on all m-c branches. I will fix m-c after bug 1240120 lands. (The code in m-c isn't being used anywhere for now, so I'd rather wait for Syd to finalize his restructuring.)

I tested my change on a few pf-jenkins branches and everything seems to work fine:
http://pf-jenkins.qa.mtv2.mozilla.com:8080/view/temp/job/temp_test-mn-mse-youtube-basic-y-nightly-mac/73/console
http://pf-jenkins.qa.mtv2.mozilla.com:8080/view/temp/job/temp_mn-mse-bw-limits-youtube-default-nightly-mac/3/consoleFull

Comment 3

2 years ago
Comment on attachment 8710493 [details] [review]
Link to Github pull-request: https://github.com/mjzffr/firefox-media-tests/pull/37

This cannot be closed until the mozilla-central version is in tree, but the github version is good to go.
Attachment #8710493 - Flags: review?(spolk) → review+
(Assignee)

Comment 4

2 years ago
> This cannot be closed until the mozilla-central version is in tree

Agreed. As discussed, I have the m-c patch ready but I will hold off until bug 1240120 lands.

Updated

2 years ago
Depends on: 1240120
(Assignee)

Comment 5

2 years ago
Merged and rebased onto pf-jenkins branch
https://github.com/mjzffr/firefox-media-tests/commit/20c19d094e67cef81f9b33e2f7e5d00a3d9c23ec

This means that media jobs running in pf-jenkins are using the latest marionette-* releases (i.e. bug 1238996)

Updated

2 years ago
Blocks: 1238648

Comment 6

2 years ago
Created attachment 8711103 [details]
MozReview Request: Bug 1240991 - Remove __init__ from FirefoxMediaHarness and update requirements. r?maja_zf

Review commit: https://reviewboard.mozilla.org/r/31977/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/31977/
Attachment #8711103 - Flags: review?(mjzffr)
(Assignee)

Comment 7

2 years ago
Comment on attachment 8711103 [details]
MozReview Request: Bug 1240991 - Remove __init__ from FirefoxMediaHarness and update requirements. r?maja_zf

https://reviewboard.mozilla.org/r/31977/#review28713
Attachment #8711103 - Flags: review?(mjzffr) → review+

Comment 8

2 years ago
Comment on attachment 8711103 [details]
MozReview Request: Bug 1240991 - Remove __init__ from FirefoxMediaHarness and update requirements. r?maja_zf

https://reviewboard.mozilla.org/r/31977/#review28715
Attachment #8711103 - Flags: review+

Comment 10

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/31822653c9a4
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox46: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla46

Updated

5 months ago
Product: Testing → Testing Graveyard
You need to log in before you can comment on or make changes to this bug.