1240991 - Remove __init__ from FirefoxMediaHarness and update requirements

Status: RESOLVED FIXED

(Testing Graveyard :: external-media-tests, defect, P1)

Description

[Maja Frydrychowicz :impossibus (was :maja_zf) (needinfo me)]

FirefoxMediaHarness.__init__ implements a workaround for Bug 1227918. Let's remove it! 

It also breaks as a result of adding the 'args' keyword argument to the call to `harness_class` in runtests:cli [1,2], so let's remove it quickly!

[1] https://dxr.mozilla.org/mozilla-central/source/testing/marionette/client/marionette/runtests.py#91
[2] https://hg.mozilla.org/mozilla-central/rev/853bcd30706a

Comment 1

[Maja Frydrychowicz :impossibus (was :maja_zf) (needinfo me)]

I need to fix both the github repo and m-c, because the github repo is still referenced by buildbot jobs on all m-c branches. I will fix m-c after bug 1240120 lands. (The code in m-c isn't being used anywhere for now, so I'd rather wait for Syd to finalize his restructuring.)

I tested my change on a few pf-jenkins branches and everything seems to work fine:
http://pf-jenkins.qa.mtv2.mozilla.com:8080/view/temp/job/temp_test-mn-mse-youtube-basic-y-nightly-mac/73/console
http://pf-jenkins.qa.mtv2.mozilla.com:8080/view/temp/job/temp_mn-mse-bw-limits-youtube-default-nightly-mac/3/consoleFull

Comment 2

[Maja Frydrychowicz :impossibus (was :maja_zf) (needinfo me)]

Attachment: Link to Github pull-request: https://github.com/mjzffr/firefox-media-tests/pull/37

Comment 3

[Syd Polk :sydpolk]

Comment on attachment 8710493 [details] [review]
Link to Github pull-request: https://github.com/mjzffr/firefox-media-tests/pull/37

This cannot be closed until the mozilla-central version is in tree, but the github version is good to go.

Comment 4

[Maja Frydrychowicz :impossibus (was :maja_zf) (needinfo me)]

> This cannot be closed until the mozilla-central version is in tree

Agreed. As discussed, I have the m-c patch ready but I will hold off until bug 1240120 lands.

Comment 5

[Maja Frydrychowicz :impossibus (was :maja_zf) (needinfo me)]

Merged and rebased onto pf-jenkins branch
https://github.com/mjzffr/firefox-media-tests/commit/20c19d094e67cef81f9b33e2f7e5d00a3d9c23ec

This means that media jobs running in pf-jenkins are using the latest marionette-* releases (i.e. bug 1238996)

Comment 6

[Syd Polk :sydpolk]

Attachment: MozReview Request: Bug 1240991 - Remove __init__ from FirefoxMediaHarness and update requirements. r?maja_zf

Review commit: https://reviewboard.mozilla.org/r/31977/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/31977/

Comment 7

[Maja Frydrychowicz :impossibus (was :maja_zf) (needinfo me)]

Comment on attachment 8711103 [details]
MozReview Request: Bug 1240991 - Remove __init__ from FirefoxMediaHarness and update requirements. r?maja_zf

https://reviewboard.mozilla.org/r/31977/#review28713

Comment 8

[Syd Polk :sydpolk]

Comment on attachment 8711103 [details]
MozReview Request: Bug 1240991 - Remove __init__ from FirefoxMediaHarness and update requirements. r?maja_zf

https://reviewboard.mozilla.org/r/31977/#review28715

Comment 9

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/31822653c9a4

Comment 10

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/31822653c9a4