Closed
Bug 1241117
Opened 10 years ago
Closed 10 years ago
Impossible to connect to a Bluetooth LE device via GATT
Categories
(Core :: DOM: Device Interfaces, defect)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox46 | --- | fixed |
People
(Reporter: cwiiis, Assigned: cwiiis)
Details
Attachments
(1 file)
|
1.53 KB,
patch
|
yrliou
:
review+
|
Details | Diff | Splinter Review |
A logic error is currently making it impossible to connect to any Bluetooth LE device (after bug 1222956).
Nominating to block 2.6 - I don't know what our criteria is for 2.6 blockers, or when we're going to release, but given we're meant to be pivoting to IoT, I'd have thought this would be important.
Attachment #8709959 -
Flags: review?(joliu)
|
||
Comment 1•10 years ago
|
||
Comment on attachment 8709959 [details] [diff] [review]
0001-Bug-XXX-Fix-logic-error-in-BluetoothGatt-Connect.-r.patch
Review of attachment 8709959 [details] [diff] [review]:
-----------------------------------------------------------------
Thanks for finding and fixing this bug.
I would suggest to revise the commit message as 'Bug 1241117 - Fix incorrect timing of converting mAppUuid string to |BluetoothUuid| in |BluetoothGatt::Connect()|.' to be more clear.
Attachment #8709959 -
Flags: review?(joliu) → review+
|
Assignee | |
Comment 2•10 years ago
|
||
Thanks for the fast review! Amended commit message and pushed to inbound:
https://hg.mozilla.org/integration/mozilla-inbound/rev/019edfe06f9d
|
||
Updated•10 years ago
|
blocking-b2g: 2.6? → 2.6+
Target Milestone: --- → 2.6 S6 - 1/29
|
||
Comment 3•10 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
status-firefox46:
--- → fixed
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•