1241301 - Use PR_LogPrint in purplexpcom following Bug 1174972

Status: RESOLVED FIXED

(Chat Core :: General, defect)

Description

[aleth [:aleth]]

Bustage from bug 1174972:
    56:51.14 Undefined symbols for architecture x86_64:
    56:51.14   "mozilla::detail::log_print(PRLogModuleInfo const*, mozilla::LogLevel, char const*, ...)", referenced from:
    56:51.14       purpleAccount::purpleAccount() in purpleAccount.o
    56:51.14       purpleAccount::~purpleAccount() in purpleAccount.o
    56:51.14       purpleAccount::Remove() in purpleAccount.o
    56:51.14       purpleAccount::Init(imIAccount*, prplIProtocol*) in purpleAccount.o
    56:51.14       purpleAccount::ApplyCurrentUserIcon() in purpleAccount.o
    56:51.15       purpleAccount::Connect() in purpleAccount.o
    56:51.15       purpleAccount::Disconnect() in purpleAccount.o 

We can resolve this similarly to how that bug handles netwerk/test, by redefining MOZ_LOG to use PR_LogPrint instead.

Comment 1

[aleth [:aleth]]

Attachment: Use PR_LogPrint in purplexpcom following Bug 1174972

Comment 2

[Patrick Cloke [:clokep]]

Comment on attachment 8710155 [details] [diff] [review]
Use PR_LogPrint in purplexpcom following Bug 1174972

Works for me. The header ordering in those files is weird, but I don't have a comment on making them better.

Comment 3

[aleth [:aleth]]

https://hg.mozilla.org/users/florian_queze.net/purple/rev/17fc639a64bd

Comment 4

[Florian Quèze [:florian]]

(In reply to Patrick Cloke [:clokep] from comment #2)
> The header ordering in those files is weird, but I don't have
> a comment on making them better.

FWIW, they used to be alphabetically ordered, with the " headers (local headers) and the <> headers (platform/system headers) grouped together. There may have been a few exceptions due to inclusion order constraints. And some more unintended exceptions.