Use PR_LogPrint in purplexpcom following Bug 1174972

RESOLVED FIXED in Instantbird 46

Status

Chat Core
General
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: aleth, Assigned: aleth)

Tracking

trunk
Instantbird 46

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

2 years ago
Bustage from bug 1174972:
    56:51.14 Undefined symbols for architecture x86_64:
    56:51.14   "mozilla::detail::log_print(PRLogModuleInfo const*, mozilla::LogLevel, char const*, ...)", referenced from:
    56:51.14       purpleAccount::purpleAccount() in purpleAccount.o
    56:51.14       purpleAccount::~purpleAccount() in purpleAccount.o
    56:51.14       purpleAccount::Remove() in purpleAccount.o
    56:51.14       purpleAccount::Init(imIAccount*, prplIProtocol*) in purpleAccount.o
    56:51.14       purpleAccount::ApplyCurrentUserIcon() in purpleAccount.o
    56:51.15       purpleAccount::Connect() in purpleAccount.o
    56:51.15       purpleAccount::Disconnect() in purpleAccount.o 

We can resolve this similarly to how that bug handles netwerk/test, by redefining MOZ_LOG to use PR_LogPrint instead.
(Assignee)

Comment 1

2 years ago
Created attachment 8710155 [details] [diff] [review]
Use PR_LogPrint in purplexpcom following Bug 1174972
Attachment #8710155 - Flags: review?(clokep)
(Assignee)

Updated

2 years ago
Assignee: nobody → aleth
Status: NEW → ASSIGNED
(Assignee)

Updated

2 years ago
Blocks: 1174972
Comment on attachment 8710155 [details] [diff] [review]
Use PR_LogPrint in purplexpcom following Bug 1174972

Works for me. The header ordering in those files is weird, but I don't have a comment on making them better.
Attachment #8710155 - Flags: review?(clokep) → review+
(Assignee)

Comment 3

2 years ago
https://hg.mozilla.org/users/florian_queze.net/purple/rev/17fc639a64bd
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Instantbird 46
(In reply to Patrick Cloke [:clokep] from comment #2)
> The header ordering in those files is weird, but I don't have
> a comment on making them better.

FWIW, they used to be alphabetically ordered, with the " headers (local headers) and the <> headers (platform/system headers) grouped together. There may have been a few exceptions due to inclusion order constraints. And some more unintended exceptions.
You need to log in before you can comment on or make changes to this bug.