1241339 - ObserverService may keep Console object alive until shutdown

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Olli Pettay [:smaug][[e-mail]]]

Attachment: test

patch coming

Comment 1

[Olli Pettay [:smaug][[e-mail]]]

that expando in the test shouldn't even be needed.

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

Attachment: v1

This is the safest possible, even for branches, I could think of.
We may want to tweak that notification firing for this kind of edge cases too.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=cf5cab10df61

I'm not sure if this helps with bug 1241271

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

Opt builds https://treeherder.mozilla.org/#/jobs?repo=try&revision=5afd0fa1bd95

smaug	does tryserver have links to the place where one can download the builds?
smaug	s/tryserver/treeherder/ perhaps
RyanVM|afk	smaug: yes
RyanVM|afk	smaug: click on the B in question
RyanVM|afk	bottom left pane
RyanVM|afk	Build: <some linkified name>
RyanVM|afk	i.e. Build: x86_64 linux64 linux
RyanVM|afk	that'll take you to the build dir

Comment 4

[Olli Pettay [:smaug][[e-mail]]]

Jukka, want to test those tryserver builds whether it helps with the leak?

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/95a25c159a0e

Comment 6

[Jukka Jylänki]

Thanks Olli, I'll update to use this build as soon as it lands to Nightly. Looks like the bug does not manifest 100% reproducibly, so I am unable to say for certainty if this fixes the issue, but I'll keep an eye out if this occurs and do CC log captures when it does.

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/95a25c159a0e