Closed Bug 1241378 Opened 4 years ago Closed 4 years ago

stop uselessly getting the style set from nsStyleSet::ResolveAnonymousBoxStyle

Categories

(Core :: CSS Parsing and Computation, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla46
Tracking Status
firefox46 --- fixed

People

(Reporter: heycam, Assigned: heycam)

References

Details

Attachments

(1 file)

Attached patch patchSplinter Review
* a style set is created with a pointer to a pres context
* a pres context has a 1:1 relationship with a pres shell that doesn't change
* a pres shell is created with a pointer to a style set
* a pres context can return its style set by grabbing it from the pres shell

Thus the PresContext()->GetStyle() call in nsStyleSet::ResolveAnonymousBoxStyle is unnecessary.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=b0e519c1c8d9
Attachment #8710255 - Flags: review?(dholbert)
Adding dependency on bug 115199, which is where this line was added:
  http://hg.mozilla.org/mozilla-central/rev/2ea5d36b35a1#l11.17

If there's no rush to fix this (I suspect not), I'd prefer that dbaron be the reviewer here, since he was the one to review that patch & would know if there's some subtle reason that this needs to be the way it is.
Depends on: 115199
Comment on attachment 8710255 [details] [diff] [review]
patch

Review of attachment 8710255 [details] [diff] [review]:
-----------------------------------------------------------------

...though on second thought, this seems trivial enough, and the logic in comment 0 makes sense. (and I clicked through MXR for nsStyleSet / presshell initialization code as a sanity-check, and it agrees with comment 0.)

So, I'm happy r+'ing this.
Attachment #8710255 - Flags: review?(dholbert) → review+
https://hg.mozilla.org/mozilla-central/rev/436d69e34651
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla46
Blocks: stylo
You need to log in before you can comment on or make changes to this bug.