1241378 - stop uselessly getting the style set from nsStyleSet::ResolveAnonymousBoxStyle

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect)

Description

[Cameron McCormack (:heycam)]

Attachment: patch

* a style set is created with a pointer to a pres context
* a pres context has a 1:1 relationship with a pres shell that doesn't change
* a pres shell is created with a pointer to a style set
* a pres context can return its style set by grabbing it from the pres shell

Thus the PresContext()->GetStyle() call in nsStyleSet::ResolveAnonymousBoxStyle is unnecessary.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=b0e519c1c8d9

Comment 1

[Daniel Holbert [:dholbert]]

Adding dependency on bug 115199, which is where this line was added:
  http://hg.mozilla.org/mozilla-central/rev/2ea5d36b35a1#l11.17

If there's no rush to fix this (I suspect not), I'd prefer that dbaron be the reviewer here, since he was the one to review that patch & would know if there's some subtle reason that this needs to be the way it is.

Comment 2

[Daniel Holbert [:dholbert]]

Comment on attachment 8710255 [details] [diff] [review]
patch

Review of attachment 8710255 [details] [diff] [review]:
-----------------------------------------------------------------

...though on second thought, this seems trivial enough, and the logic in comment 0 makes sense. (and I clicked through MXR for nsStyleSet / presshell initialization code as a sanity-check, and it agrees with comment 0.)

So, I'm happy r+'ing this.

Comment 3

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/436d69e34651

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/436d69e34651