Closed
Bug 1241399
Opened 9 years ago
Closed 9 years ago
[TV][2.5][Web Apps] First time opening tutorial, background image will late shown
Categories
(Firefox OS Graveyard :: Gaia::TV, defect, P1)
Tracking
(Not tracked)
VERIFIED
FIXED
People
(Reporter: mlien, Assigned: jyeh)
References
Details
(Whiteboard: [ft:conndevices])
Attachments
(3 files)
[Description] First time to use Web Apps, tutorial show up but the background image will much late than Next button and string on top of screen [Reproduce Steps] 1. Launch Apps -> Web Apps/Dev Web Apps [Build Information] Environment: 2.5 Simulator Gaia: https://github.com/mozilla-b2g/gaia/commit/184523b202608f24e01cda720370de3ee7c5b8c3 Gecko: https://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/be1ec31308366db734d15a04db7c4b4697515b20 Mulet: https://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/be1ec31308366db734d15a04db7c4b4697515b20 [Expected Result] Show full tutorial at the same time, no matter button, string, or image [Actual Result] Background image show up much late than button and string Please help to check with attachment, thanks.
Reporter | ||
Updated•9 years ago
|
QA Whiteboard: [COM=TV::Web Apps]
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → jyeh
Status: NEW → ASSIGNED
Assignee | ||
Comment 1•9 years ago
|
||
Hi Davor, When tutorial image loads for the first time, it takes some time so the strings and the button will show up first with blank background. I made a lazy load function in this patch which ensure the content show up after the image had loaded. I am not sure if this is the best solution, if you have any better practices, please let me know. Thanks :)
Attachment #8710930 -
Flags: review?(dspasovski)
Assignee | ||
Comment 2•9 years ago
|
||
Hi Davor, I need your advise on this patch, can you take a look at it? Thanks.
Flags: needinfo?(dspasovski)
Comment 3•9 years ago
|
||
Commented in the PR, looks good overall just needs some tweaking.
Flags: needinfo?(dspasovski)
Updated•9 years ago
|
Attachment #8710930 -
Flags: review?(dspasovski) → review+
Assignee | ||
Comment 4•9 years ago
|
||
Landed in marketplace-tv-front-end master. https://github.com/mozilla-b2g/marketplace-tv-front-end/commit/72b22c5c31d148be137c590b95ad4963fbc6f258
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Reporter | ||
Comment 5•9 years ago
|
||
verified and fixed with the latest 2.5 build
Status: RESOLVED → VERIFIED
Assignee | ||
Comment 6•9 years ago
|
||
According to the comment from previous review (https://github.com/mozilla-b2g/marketplace-tv-front-end/pull/33#discussion_r50894461), this patch will add a spinner when the tutorial image is loading. Thanks for Helen's help.
Assignee | ||
Comment 7•9 years ago
|
||
Landed in marketplace-tv-front-end master. https://github.com/mozilla-b2g/marketplace-tv-front-end/commit/a6a25e35f2c19b79fb1c883f214f7d573a4f2503
You need to log in
before you can comment on or make changes to this bug.
Description
•