1241531 - fix some job queue issues found through code inspection

Status: RESOLVED FIXED

(Core :: DOM: Service Workers, defect)

Description

[Ben Kelly [:bkelly, not reviewing]]

I see a few issues in the service worker job queue code.  I don't have any failing tests, but it would be nice to close these up.

Comment 1

[Ben Kelly [:bkelly, not reviewing]]

Attachment: P1 Only pop jobs from the queue when the correct job completes. r=ehsan

Comment 2

[Ben Kelly [:bkelly, not reviewing]]

Attachment: P2 Move Cancel() to ServiceWorkerJob base class. r=ehsan

Comment 3

[Ben Kelly [:bkelly, not reviewing]]

Attachment: P3 Call Cancel() on all service worker jobs. r=ehsan

Comment 4

[Ben Kelly [:bkelly, not reviewing]]

Attachment: P4 Make service worker unregister job respect cancelation. r=ehsan

https://treeherder.mozilla.org/#/jobs?repo=try&revision=53a0d2748174

Comment 5

[Ben Kelly [:bkelly, not reviewing]]

On my mobile so I can't star in treeherder easily, but all the try orange looks like known intermittent to me.

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/cca3ee01a862
https://hg.mozilla.org/integration/mozilla-inbound/rev/62452453a636
https://hg.mozilla.org/integration/mozilla-inbound/rev/9979b9c3314a
https://hg.mozilla.org/integration/mozilla-inbound/rev/ae7300dbece6

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/cca3ee01a862
https://hg.mozilla.org/mozilla-central/rev/62452453a636
https://hg.mozilla.org/mozilla-central/rev/9979b9c3314a
https://hg.mozilla.org/mozilla-central/rev/ae7300dbece6

Comment 8

[Ben Kelly [:bkelly, not reviewing]]

Comment on attachment 8710515 [details] [diff] [review]
P1 Only pop jobs from the queue when the correct job completes. r=ehsan

For all 4 patches.

Approval Request Comment
[Feature/regressing bug #]: service workers
[User impact if declined]: Possible crash if certain code paths are hit.
[Describe test coverage new/current, TreeHerder]:  Current mochitests ensure no regressions, but we don't have a test that provokes the crash.
[Risks and why]: Minimal.  Only affects service workers.
[String/UUID change made/needed]: None

Comment 9

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8710515 [details] [diff] [review]
P1 Only pop jobs from the queue when the correct job completes. r=ehsan

Fix a crash, taking it.

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/b0e72ac2a04a
https://hg.mozilla.org/releases/mozilla-aurora/rev/e447e2dffa47
https://hg.mozilla.org/releases/mozilla-aurora/rev/ebe66fdceb89
https://hg.mozilla.org/releases/mozilla-aurora/rev/840b94bdff0c