Closed Bug 1241531 Opened 4 years ago Closed 4 years ago

fix some job queue issues found through code inspection

Categories

(Core :: DOM: Service Workers, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla46
Tracking Status
firefox44 --- wontfix
firefox45 --- fixed
firefox46 --- fixed

People

(Reporter: bkelly, Assigned: bkelly)

References

Details

Attachments

(4 files)

I see a few issues in the service worker job queue code.  I don't have any failing tests, but it would be nice to close these up.
Attachment #8710515 - Flags: review?(ehsan) → review+
Attachment #8710517 - Flags: review?(ehsan) → review+
Attachment #8710518 - Flags: review?(ehsan) → review+
Attachment #8710519 - Flags: review?(ehsan) → review+
On my mobile so I can't star in treeherder easily, but all the try orange looks like known intermittent to me.
Keywords: checkin-needed
Comment on attachment 8710515 [details] [diff] [review]
P1 Only pop jobs from the queue when the correct job completes. r=ehsan

For all 4 patches.

Approval Request Comment
[Feature/regressing bug #]: service workers
[User impact if declined]: Possible crash if certain code paths are hit.
[Describe test coverage new/current, TreeHerder]:  Current mochitests ensure no regressions, but we don't have a test that provokes the crash.
[Risks and why]: Minimal.  Only affects service workers.
[String/UUID change made/needed]: None
Attachment #8710515 - Flags: approval-mozilla-aurora?
Comment on attachment 8710515 [details] [diff] [review]
P1 Only pop jobs from the queue when the correct job completes. r=ehsan

Fix a crash, taking it.
Attachment #8710515 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Depends on: 1244330
You need to log in before you can comment on or make changes to this bug.