Closed
Bug 1241549
Opened 9 years ago
Closed 9 years ago
Annotate intentional switch fallthrough in hal/linux/UPowerClient.cpp
Categories
(Core :: Hardware Abstraction Layer (HAL), defect)
Core
Hardware Abstraction Layer (HAL)
Tracking
()
RESOLVED
FIXED
mozilla46
| Tracking | Status | |
|---|---|---|
| firefox46 | --- | fixed |
People
(Reporter: cpeterson, Assigned: cpeterson)
References
Details
Attachments
(1 file)
|
1.57 KB,
patch
|
gsvelto
:
review+
|
Details | Diff | Splinter Review |
clang's -Wimplicit-fallthrough warnings (not yet enabled in mozilla-central) warn about switch cases that fall through without a break or return statement. MOZ_FALLTHROUGH (bug 1215411) is an annotation to suppress -Wimplicit-fallthrough warnings where the fallthrough is intentional.
hal/linux/UPowerClient.cpp:420:5: warning: unannotated fall-through between switch labels [-Wimplicit-fallthrough]
Attachment #8710543 -
Flags: review?(gsvelto)
|
||
Comment 1•9 years ago
|
||
Comment on attachment 8710543 [details] [diff] [review]
hal_MOZ_FALLTHROUGH.patch
LGTM, thanks.
Attachment #8710543 -
Flags: review?(gsvelto) → review+
|
Assignee | |
Comment 2•9 years ago
|
||
Thanks!
|
||
Comment 4•9 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox46:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla46
You need to log in
before you can comment on or make changes to this bug.
Description
•