Annotate intentional switch fallthrough in hal/linux/UPowerClient.cpp

RESOLVED FIXED in Firefox 46

Status

()

RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: cpeterson, Assigned: cpeterson)

Tracking

unspecified
mozilla46
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox46 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
Created attachment 8710543 [details] [diff] [review]
hal_MOZ_FALLTHROUGH.patch

clang's -Wimplicit-fallthrough warnings (not yet enabled in mozilla-central) warn about switch cases that fall through without a break or return statement. MOZ_FALLTHROUGH (bug 1215411) is an annotation to suppress -Wimplicit-fallthrough warnings where the fallthrough is intentional.

hal/linux/UPowerClient.cpp:420:5: warning: unannotated fall-through between switch labels [-Wimplicit-fallthrough]
Attachment #8710543 - Flags: review?(gsvelto)
Comment on attachment 8710543 [details] [diff] [review]
hal_MOZ_FALLTHROUGH.patch

LGTM, thanks.
Attachment #8710543 - Flags: review?(gsvelto) → review+
(Assignee)

Comment 2

3 years ago
Thanks!

Comment 4

3 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/70cf73861853
Status: NEW → RESOLVED
Last Resolved: 3 years ago
status-firefox46: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla46
(Assignee)

Updated

3 years ago
Blocks: 1253170
You need to log in before you can comment on or make changes to this bug.