Closed Bug 1241549 Opened 7 years ago Closed 7 years ago

Annotate intentional switch fallthrough in hal/linux/UPowerClient.cpp

Categories

(Core :: Hardware Abstraction Layer (HAL), defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla46
Tracking Status
firefox46 --- fixed

People

(Reporter: cpeterson, Assigned: cpeterson)

References

Details

Attachments

(1 file)

clang's -Wimplicit-fallthrough warnings (not yet enabled in mozilla-central) warn about switch cases that fall through without a break or return statement. MOZ_FALLTHROUGH (bug 1215411) is an annotation to suppress -Wimplicit-fallthrough warnings where the fallthrough is intentional.

hal/linux/UPowerClient.cpp:420:5: warning: unannotated fall-through between switch labels [-Wimplicit-fallthrough]
Attachment #8710543 - Flags: review?(gsvelto)
Comment on attachment 8710543 [details] [diff] [review]
hal_MOZ_FALLTHROUGH.patch

LGTM, thanks.
Attachment #8710543 - Flags: review?(gsvelto) → review+
Thanks!
https://hg.mozilla.org/mozilla-central/rev/70cf73861853
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla46
Blocks: 1253170
You need to log in before you can comment on or make changes to this bug.