Closed Bug 1241622 Opened 4 years ago Closed 4 years ago

Switch SeaMonkey to HTTP cache v2

Categories

(SeaMonkey :: General, defect)

defect
Not set
major

Tracking

(seamonkey2.47 unaffected, seamonkey2.48 fixed)

RESOLVED FIXED
seamonkey2.48
Tracking Status
seamonkey2.47 --- unaffected
seamonkey2.48 --- fixed

People

(Reporter: mayhemer, Assigned: rsx11m.pub)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

I quickly looked at the sources and seem like c-c/suite is converted to use cache2 APIs.  So this is only about switching a pref: browser.cache.use_new_backend = 1.  Testing with that pref shows it seems to work well.
Blocks: 1233744
We did go to /cache2/, but there was a bug with that that affected the Mail end (and likewise Thunderbird), so we (both) reverted back to /cache/.
Note that soon (this year) we will remove cache v1 code altogether.
And Thunderbird now uses cache2, AFAIK.
(In reply to Honza Bambas (:mayhemer) from comment #3)
> And Thunderbird now uses cache2, AFAIK.
Nope!

http://mxr.mozilla.org/comm-central/source/mail/app/profile/all-thunderbird.js?rev=79455af1ccff#857

> // Disable cache v2 since migration has not been done, it is pending in bug 1021843.
> pref("browser.cache.use_new_backend",       0);
> pref("browser.cache.use_new_backend_temp",  false);
Depends on: mail-cache2
(In reply to Philip Chee from comment #4)
> (In reply to Honza Bambas (:mayhemer) from comment #3)
> > And Thunderbird now uses cache2, AFAIK.
> Nope!

Now it does, Bug 1021843 - Migrate NNTP and IMAP to cache2 :-)
http://hg.mozilla.org/comm-central/rev/c679c89e86ba

The patch simply removes the pref overrides in browser-prefs.js to pick up the defaults as Thunderbird did, thus enabling the use of cache2 for SeaMonkey (assuming that bug 1021843 isn't backed out again).

(In reply to Honza Bambas (:mayhemer) from comment #0)
> So this is only about switching a pref: browser.cache.use_new_backend = 1.

(In reply to Magnus Melin from bug 1021843 comment #69)
> ::: mail/app/profile/all-thunderbird.js
> @@ +863,1 @@
> >  pref("browser.cache.use_new_backend",       0);
> 
> hmm, this seems like a dead pref(?)

This is actually quite confusing. Despite browser.cache.use_new_backend defaulting to 0 in all.js, browser.cache.use_new_backend_temp -> true implies *1* per https://dxr.mozilla.org/comm-central/source/mozilla/netwerk/cache2/CacheObserver.cpp#300 in CacheObserver::UseNewCache().
Assignee: nobody → rsx11m.pub
Status: NEW → ASSIGNED
Attachment #8786528 - Flags: review?(philip.chee)
Comment on attachment 8786528 [details] [diff] [review]
Remove pref overrides

(In reply to rsx11m from comment #5)
> The patch simply removes the pref overrides in browser-prefs.js to pick up
> the defaults as Thunderbird did, thus enabling the use of cache2 for
> SeaMonkey (assuming that bug 1021843 isn't backed out again).
I have no intention to back this out ;-)

You really need to remove these preferences or you're busted.
Attachment #8786528 - Flags: review+
I assume the browser part comes from M-C and already handles cache2.
Comment on attachment 8786528 [details] [diff] [review]
Remove pref overrides

r=me a=me
Attachment #8786528 - Flags: review?(philip.chee) → review+
Thanks, landed as http://hg.mozilla.org/comm-central/rev/57ccfe130874 with adjusted commit message.
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
OS: Unspecified → All
Hardware: Unspecified → All
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.48
You need to log in before you can comment on or make changes to this bug.