Associate account conversions with onboarding experiments

RESOLVED FIXED in Firefox 46



3 years ago
3 years ago


(Reporter: Margaret, Assigned: mfinkle)


Firefox 47

Firefox Tracking Flags

(firefox46 fixed, firefox47 fixed, fennec46+)



(1 attachment)



3 years ago
We could do this with UI telemetry, or maybe we could pass a parameter to the FxA server so that the cloud services folks can do this association for us.
I think it's sensible to add UI telemetry for the major things that happen in response to FxA WebChannel messages.  See

In particular, the following are relevant to the browser and are probably interesting to track in telemetry:

const COMMAND_LOGIN                = "fxaccounts:login";
const COMMAND_CHANGE_PASSWORD      = "fxaccounts:change_password";
const COMMAND_DELETE_ACCOUNT       = "fxaccounts:delete_account";
const COMMAND_SYNC_PREFERENCES     = "fxaccounts:sync_preferences";

Let's add a generic event for COMMAND_LOGIN (possibly with a flag to know if we created a new account or re-connected an existing account, or possibly two events for these cases).

Then we can associate the event to a particular UI telemetry session, which could include a long-lived "onboarding-X" session.
Assignee: nobody → nalexander
This patch adds a few probes for some actions.

Nick - I made assumptions about the spot to put the probes. Look right?
Margaret - I went with (ACTION, CONTENT, "fxaccount-*") which seemed OK. I don't want to make a new Event type for this and these are actions that happen in a web-based UI.

Nick - I also removed some imports you weren't using. I also made Prompt a lazy load, which is our convention since we never seem to Prompt on script load.
Assignee: nalexander → mark.finkle
Attachment #8726075 - Flags: review?(nalexander)
Attachment #8726075 - Flags: review?(margaret.leibovic)
Comment on attachment 8726075 [details] [diff] [review]
fxaccount-probes v0.1

Review of attachment 8726075 [details] [diff] [review]:


::: mobile/android/modules/FxAccountsWebChannel.jsm
@@ +331,5 @@
>                return Accounts.deleteFirefoxAccount().then(success => {
>                  if (!success) {
>                    throw new Error("Could not delete Firefox Account!");
>                  }
> +                UITelemetry.addEvent("action.1", "content", null, "fxaccount-delete");

Just a note - there are other ways to delete a Firefox Account.  I'm sure you're aware, just needs to color this data.
Attachment #8726075 - Flags: review?(nalexander) → review+

Comment 4

3 years ago
Comment on attachment 8726075 [details] [diff] [review]
fxaccount-probes v0.1

Review of attachment 8726075 [details] [diff] [review]:

Looks fine from a telemetry probe naming perspective (I defer to Nick on the correctness for where to put these probes).
Attachment #8726075 - Flags: review?(margaret.leibovic) → review+
(In reply to Nick Alexander :nalexander from comment #3)

> Just a note - there are other ways to delete a Firefox Account.  I'm sure
> you're aware, just needs to color this data.

We decided to land this patch, scoped to meet the desired needs: track FxAccount signups from onboarding.

Nick provided links to other call sites that can allow the account to be deleted. If we need to track those, we can followup in a new bug.
We should try to uplift these probes to Fx46 so we can better track the onboarding experiment.
tracking-fennec: --- → 46+
status-firefox46: --- → affected
status-firefox47: --- → affected

Comment 8

3 years ago
Last Resolved: 3 years ago
status-firefox47: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 47
Comment on attachment 8726075 [details] [diff] [review]
fxaccount-probes v0.1

Approval Request Comment
[Feature/regressing bug #]: onboarding experiment #2
[User impact if declined]: We'd miss out learning if the onboarding experiments affected fx account sign-ups
[Describe test coverage new/current, TreeHerder]: Landed on Nightly
[Risks and why]: Low. Just adding some probes and removing unused imports
[String/UUID change made/needed]: none
Attachment #8726075 - Flags: approval-mozilla-aurora?
Comment on attachment 8726075 [details] [diff] [review]
fxaccount-probes v0.1

Let's see if we can get this into 46 beta 1. please uplift.
Attachment #8726075 - Flags: approval-mozilla-beta+
Attachment #8726075 - Flags: approval-mozilla-aurora?
Attachment #8726075 - Flags: approval-mozilla-aurora-

Comment 11

3 years ago
status-firefox46: affected → fixed
You need to log in before you can comment on or make changes to this bug.